Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#3817 closed enhancement (fixed)

Tiny changes to strings in Screenshot [patch]

Reported by: humdinger Owned by: julun
Priority: normal Milestone: R1
Component: Applications/Screenshot Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev30234.

I changed a few strings in Screenshot's interface.

directory -> folder cursor -> mouse pointer Take whole Desktop -> Take whole screen

Patch included.

Attachments (2)

Screenshot-strings.diff (2.2 KB) - added by humdinger 10 years ago.
Small changes to strings in GUI
Screenshot-stringsV2.diff (8.0 KB) - added by humdinger 10 years ago.
Additionally renames every *Cursor to *Mouse.

Download all attachments as: .zip

Change History (19)

Changed 10 years ago by humdinger

Attachment: Screenshot-strings.diff added

Small changes to strings in GUI

comment:1 Changed 10 years ago by humdinger

Hmm. I just realized that there's a commandline option "-c, --cursor". This would have to become "-m, --mouse" to stay consistent.

If you agree, apply patch V2 were I renamed every *Cursor to *Mouse.

Changed 10 years ago by humdinger

Attachment: Screenshot-stringsV2.diff added

Additionally renames every *Cursor to *Mouse.

comment:2 Changed 10 years ago by julun

Hi, just go ahead and change the strings. Not sure if i like the mouse thing, still one would include the mouse cursor and not the mouse. It's up to you though.

Have fun, Karsten

comment:3 Changed 10 years ago by humdinger

Actually, it's the "mouse pointer", but having a two word parameter is bad, so I shortened to "mouse".

BTW, I happen on these semantic things when writing for the user guide. It's not like I look for something to nitpick for the fun of it... :)

comment:4 in reply to:  3 Changed 10 years ago by julun

Hi,

BTW, I happen on these semantic things when writing for the user guide. It's not like I look for something to nitpick for the fun of it... :)

I haven't taken it that way. ATM i have no time at all for Haiku, so please change it. :)

Regards, Karsten

comment:5 Changed 10 years ago by humdinger

OK. Hope you can soon re-join the fun. :) Patch applied with hrev30392. Someone has to close the ticket for me...

comment:6 Changed 10 years ago by stippi

Resolution: fixed
Status: newclosed

comment:7 in reply to:  6 Changed 10 years ago by jonas.kirilla

Please don´t use "mouse", instead use "pointer". It´s the pointer that gets depicted, not the mouse. It´s not a "mouse pointer" really. Your on-screen pointer could be moved by any human input device, like a trackpad, trackball, whatever. Would it then be a "trackball pointer"?

comment:8 Changed 10 years ago by humdinger

Resolution: fixed
Status: closedreopened

I guess it's a language thing. In German it's "Mauszeiger" and I'd even say "Click with your mouse on..." never minding the actual input device. So for me reading "include mouse pointer in screenshot" would be much clearer than reading "include pointer in screenshot". Apparently our heritage influences us on every kind of level...

But I defer to your wisdom, shouldn't anyone hurry to support my POV. :)

comment:9 in reply to:  8 Changed 10 years ago by jonas.kirilla

(Since Karsten has expressed lack of time and Humdinger has reopened the ticket because of me maybe I should take responsibility for it. If that is okay with you guys. Stippi?)

It´s primarily the CLI option that eeks me, which I think should be --pointer rather than just --mouse. I don´t mind if the GUI uses the term "mouse pointer". (After all, mice still dominate.) As long as the word "pointer" is included.

(Swedish is similar to German in this regard: "muspekare" (mus+pekare) is probably a more often used word than simply "pekare", unless you´re a programmer.)

Another thing: I think "Capture" would be more idiomatic than "Take", in "Take whole screen". I´m not saying it doesn´t meant the same thing, but I think the word "Capture" is more expected. But English is not my native language, so maybe "Take" is equally good.

comment:10 Changed 10 years ago by stippi

+1 to everything. (Go ahead and do it, Capture is better than Take...)

comment:11 Changed 10 years ago by humdinger

OK. As long as we can keep the "mouse pointer" in the GUI I'm placated. :) I can make the changes if you want, Jonas.

comment:12 Changed 10 years ago by humdinger

You know, I'm uncomfortable to keep distracting everyone with these profane details... but.
The window title "Take Screenshot" fits neatly to it's counter part "Save Screenshot" which it is replacing when pressing "Options" (which is itself weird IMO, see #3813 for a better approach). Also with "Take Screenshot" you still have the name of the app visible. When changing to "Capture" it would have to be "Capture Screen" as "Capture Screenshot" is wrong. And if we keep the title, changing the button name doesn't make sense...

Sorry for wasting your time with another bikeshed.

comment:13 Changed 10 years ago by aldeck

I understand the point made by Jonas with regard to "mouse pointer" being not generic enough, but i agree with Humdinger. I think we have to make an exception here, as any more generic wording would be paradoxicaly less understandable. I think that "mouse pointer" has grown in every language as _the_ generic meaning we all mean :)

The only change i would make to make everything consistent, is for the command line option then: "--mouse" -> "--mouse-pointer"

Concerning "Capture" vs "Take", i like "Capture" better too. Not sure having the window title change is necessary, IMO it's fine by me if it stays "Screenshot" all the time.

ps: don't be sorry Humdinger, your work is very appreciated, you know it :)

ps2: to Jonas, i think you shouldn't take the ticket since Humdinger is definitely commited to work on the issue and please everyone. It's possibly a bit rude and make him wait for unecesserary mail exchanges to continue his work.

ps3: now that your trac rights have been fixed, you can assign tickets to yourself, to show you're spending time on it.

comment:14 in reply to:  13 Changed 10 years ago by jonas.kirilla

Replying to aldeck:

ps2: to Jonas, i think you shouldn't take the ticket since Humdinger is definitely commited to work on the issue and please everyone. It's possibly a bit rude and make him wait for unecesserary mail exchanges to continue his work.

Good point. I´m sorry Humdinger - feel free to continue as you see fit! If you should find yourself disagreeing with the points I made and choose not to change anything, that´s okay too.

ps3: now that your trac rights have been fixed, you can assign tickets to yourself, to show you're spending time on it.

Another good point. Thank you, Alexandre.

I know I nitpick about details sometimes. I don´t mean to put anyone down. I very much appreciate the work put into Haiku by all of you.

comment:15 Changed 10 years ago by aldeck

np, all is fine :) There's no small bug, and i didn't see any nitpicking in the discussion, simply good arguments and certainly an eye to the details!

comment:16 Changed 10 years ago by humdinger

Resolution: fixed
Status: reopenedclosed

I didn't feel passed over, so everything's OK. :)

I just committed the changes I felt our discussion lead to. I'm still open for further improvements, though. If anyone can still work up the energy... :)

Since this worked all so easily, I'll just continue to apply my patch for ticket #3787 and deal with differing opinions later. :)

comment:17 Changed 10 years ago by humdinger

Applied patch in hrev30432

Note: See TracTickets for help on using tickets.