Canceling shutdown blames application

[jonas.kirilla]

If a user cancels shutdown early when waiting for an application to quit (say Bezilla) before the kill button appears, the resulting info alert credits the application with canceling the shutdown, whereas it was actually me, the user, who canceled the shutdown.

It might seem like a good idea to discern between the two:

• application cancels shutdown
• user cancels shutdown

When the user cancels shutdown there is no need to inform the user.

[idefix]

I have created a patch​ that will fix this bug.

[idefix]

Patch to fix registrars handling of cancelling the shutdown-process

[stippi]

Applied/fixed in hrev34253. Thanks a lot and sorry for the delay.

[stippi]

I actually wrote a test program to test the patch, but I missed something and the patch is wrong. Will investigate.

[idefix]

Strange, I tested it back then and when I clicked the Cancel while it was waiting for Terminal to close, I didn't get a notify that Terminal has stopped the shutdown process like it used to do before this patch.

[stippi]

Yes, it does that, but with your patch the error display is also not showing when it should, namely when an app returns false from QuitRequested(). Fixed this and another issue in hrev34261.

[jonas.kirilla]

Thanks, Stephan and idefix!

(in retrospect: I should have provided some feedback on the patch by idefix. A success/fail at the very least.)

[idefix]

Replying to stippi:

Yes, it does that, but with your patch the error display is also not showing when it should, namely when an app returns false from QuitRequested(). Fixed this and another issue in hrev34261.

Hmm, as I read the code now, in that case eventTeam != team, am I correct?

Shouldn't then eventTeam also be changed to team in the PRINT statement above both _DisplayAbortingApp statements in that changeset?