Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#3863 closed bug (fixed)

Canceling shutdown blames application

Reported by: jonas.kirilla Owned by: bonefish
Priority: normal Milestone: R1
Component: Servers/registrar Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

If a user cancels shutdown early when waiting for an application to quit (say Bezilla) before the kill button appears, the resulting info alert credits the application with canceling the shutdown, whereas it was actually me, the user, who canceled the shutdown.

It might seem like a good idea to discern between the two:

  • application cancels shutdown
  • user cancels shutdown

When the user cancels shutdown there is no need to inform the user.

Attachments (1)

registrar.patch (644 bytes) - added by idefix 10 years ago.
Patch to fix registrars handling of cancelling the shutdown-process

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by idefix

I have created a patch that will fix this bug.

Changed 10 years ago by idefix

Attachment: registrar.patch added

Patch to fix registrars handling of cancelling the shutdown-process

comment:2 Changed 10 years ago by stippi

Resolution: fixed
Status: newclosed

Applied/fixed in hrev34253. Thanks a lot and sorry for the delay.

comment:3 Changed 10 years ago by stippi

Resolution: fixed
Status: closedreopened

comment:4 Changed 10 years ago by stippi

I actually wrote a test program to test the patch, but I missed something and the patch is wrong. Will investigate.

comment:5 Changed 10 years ago by idefix

Strange, I tested it back then and when I clicked the Cancel while it was waiting for Terminal to close, I didn't get a notify that Terminal has stopped the shutdown process like it used to do before this patch.

comment:6 Changed 10 years ago by stippi

Resolution: fixed
Status: reopenedclosed

Yes, it does that, but with your patch the error display is also not showing when it should, namely when an app returns false from QuitRequested(). Fixed this and another issue in hrev34261.

comment:7 Changed 10 years ago by jonas.kirilla

Thanks, Stephan and idefix!

(in retrospect: I should have provided some feedback on the patch by idefix. A success/fail at the very least.)

comment:8 in reply to:  6 Changed 10 years ago by idefix

Replying to stippi:

Yes, it does that, but with your patch the error display is also not showing when it should, namely when an app returns false from QuitRequested(). Fixed this and another issue in hrev34261.

Hmm, as I read the code now, in that case eventTeam != team, am I correct?

Shouldn't then eventTeam also be changed to team in the PRINT statement above both _DisplayAbortingApp statements in that changeset?

Note: See TracTickets for help on using tickets.