BMenuItem is missing the ability to draw the modifier indicator for B_OPTION_KEY

[anevilyak]

BMenuItem contains glyph definitions and such for B_CONTROL_KEY, B_COMMAND_KEY and B_SHIFT_KEY, but not B_OPTION_KEY. As a consequence, any menu item using the key in its modifiers has its shortcut misrepresented, most notably tracker add-ons, as those use opt+cmd+letter.

[jackburton]

I'm on it

[jackburton]

Fixed in hrev30661. The look of the labels could be improved, though. Even better would be to draw them using drawing commands instead of bitmaps, so they would scale with the font size.

[anevilyak]

Replying to jackburton:

Fixed in hrev30661. The look of the labels could be improved, though. Even better would be to draw them using drawing commands instead of bitmaps, so they would scale with the font size.

Thanks! And yeah, I was thinking that too, but my skills with drawing code that actually looks eye pleasing leave some to be desired. That probably also be desirable for the internationalization GSoC project, since that'd allow us to draw localized names for the different keys.