Several small usability enhancements (mostly easy)

[humdinger]

This is hrev32111.

Quite a while back there was a ​discussion on enhancing ShowImage's usability. Here are the results, so they don't get lost:

Mouse wheel:

• zoom image; wheel up zooms in, down zooms out
• +Shift: scroll vertical
• +Alt or Ctrl: scroll horizontal

Keyboard:

• Cursor Down/Right: next image
• Cursor Up/Left: previous image
• Shift+Cursor: move image
• Alt+Return: toggle fullscreen
• Alt+R: rotate right (clockwise)
• Alt+Shift+R: rotate left (counterclockwise)

[leavengood]

I guess Christian got busy optimizing the app_server bilinear scaling to work on this. I just reread that whole thread, wow can we get into some discussions!

I think you have summarized it well though and I am going to work on these, with the addition of:

• changing the ShowImage code to use the aforementioned app_server scaling instead of it's own.
• zooming into the mouse if it is in the window, otherwise to the center.

[humdinger]

Thanks for looking into it, Ryan.

I have one more issue:
We have "Zoom to Window" to enlarge a smaller image to fit the windows.
We have "Shrink to Window" to scale down a larger image to fit the window.

What always stays the same ATM, is the window size.
What's missing is an option that changes the window size to fit the image. I'm even of the opinion that this should be the default, and what we're really missing is a "Keep Window Size" option.

[leavengood]

Replying to humdinger:

I have one more issue:
We have "Zoom to Window" to enlarge a smaller image to fit the windows.
We have "Shrink to Window" to scale down a larger image to fit the window.

I actually discovered an old TODO of mine to remove those two options and replace them with one: "Scale to Fit". I've always found them both a bit awkward. Actually I don't really see the utility of "Zoom to Window" at all. Especially once we have mouse wheel zooming. So maybe I'll just rename "Shrink to Window" as "Scale to Fit" or "Scale to Window". Or just leave it and remove "Zoom to Window".

What always stays the same ATM, is the window size.
What's missing is an option that changes the window size to fit the image. I'm even of the opinion that this should be the default, and what we're really missing is a "Keep Window Size" option.

Actually I'm pretty sure this is what ShowImage does by default. But I'll look at it more closely.

I'm also going to consider re-arranging the menus some, as what should be settings (like the slideshow delay) are under the View menu.

[humdinger]

Replying to leavengood:

I actually discovered an old TODO of mine to remove those two options and replace them with one: [...] "Scale to Window".

Good call!

What's missing is an option that changes the window size to fit the image. I'm even of the opinion that this should be the default, and what we're really missing is a "Keep Window Size" option.

Actually I'm pretty sure this is what ShowImage does by default. But I'll look at it more closely.

It dosen't. Nevertheless, an option to "Lock Window Size" is a good idea.

I'm also going to consider re-arranging the menus some, as what should be settings (like the slideshow delay) are under the View menu.

You do that. :)
And change the fullscreen shortcut to ALT+RETURN. That has been discussed as well some time ago...

[leavengood]

I've implemented the enhancements from the original ticket in hrev32343. But I'm going to leave this ticket open to address the other things I mentioned.

[humdinger]

May I add another little thing to your workload? :)

The "Use as Desktop Background" should IMO not set the current image as background directly, but open the Backgrounds preferences with that image pre-set. From here the user can decide to use as is and click "Apply" (just one additional click in this case). OTOH, he can also decide to set for all workspaces, stretch/tile/position manually or also set the icon-outline option if it's a very bright image.

I'd change the title to "Use as Background", because we have multiple workspaces. Also, don't forget the context menu, ATM the title is different there: "As Desktop Background".

[diver]

Alt or Ctrl: scroll horizontal still doesn't work in hrev32345.
And is there a need in black border (1px) around the image?

[leavengood]

Replying to diver:

Alt or Ctrl: scroll horizontal still doesn't work in hrev32345.

I assume you mean when using the mouse wheel? It works for me. It is using the command key so by default that means the left Alt key. If you switch to Windows/Linux shortcut mode it should be either Ctrl key.

And is there a need in black border (1px) around the image?

That has always been there for aesthetics I guess, I'll try taking it out and see how it looks.

[humdinger]

FWIW, at least with hrev32420, horizontal scrolling with COM+mouswheel doesn't work here either. Also, SHIFT+cursor keys doesn't move the image. Maybe you have a few uncommited changes locally?

[streak]

a small enhancement: Saving default save-folder in config file , so you dont need to start always from /boot/home [ not so handy if operates on big amount of files ]

[humdinger]

All the issues are meanwhile solved. Put streak's suggestion into #6766.