Exchanging modifier keys doen't work

[humdinger]

This is hrev32241.

Normally, left-dragging a key copies it over the key you drop it, right-dragging exchanges the two keys (BTW: I'm for reversing the logic, as left-dragging is the more common action and exchanging is less destructive).

Anyway, dragging a modifier key (SHIFT, COM, CTRL etc.) onto another /always/ copies, no matter what mouse button is used.

Also, the whole upper row of keys (ESC, Fx-keys etc.) are neither copyable nor exchangeable.

[axeld]

The reasoning behind the current drag&drop behaviour is consistency: dropping a key from anywhere works in exactly the same way. Furthermore, exchanging keys isn't very obvious when you do it from different "planes" (ie. with and without modifier).

To make it less destructive, the previous mapped character is copied to the preview text control.

Anyway, that was my reasoning, I don't mean to say it's the ideal solution. Comments welcome, as always :-)

[axeld]

Fixed in hrev32490; modifiers are actually always switched, never copied (as there is no way to recover from a lost one). So much for the consistency :-)

The F-keys (unlike Escape, which works fine over here) cannot be copied in a useful way, because they are not mapped - you always only get their character code.

[jonas.kirilla]

If you're exchanging more than two keys, doesn't it become a bit of a puzzle?

A scratch area with a couple of empty keys could help some people. It wouldn't have to show all the time.