Opened 5 years ago

Closed 22 months ago

#4244 closed bug (fixed)

Can't remove pulse replicants.

Reported by: kvdman Owned by: stpere
Priority: normal Milestone: R1
Component: Applications/Pulse Version: R1/alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: x86

Description

On dual processor machines (or greater), when you start Pulse and drag out a replicant for the processor to the desktop, there's no way to remove it besides deleting tracker_shelf and restarting.

Attachments (1)

screenshot1.png (13.7 KB) - added by piegod 5 years ago.
Not so useful... but attached anyway.

Download all attachments as: .zip

Change History (19)

Changed 5 years ago by piegod

Not so useful... but attached anyway.

comment:1 Changed 5 years ago by piegod

  • Platform changed from All to x86
  • Version changed from R1/pre-alpha1 to R1/alpha1

Can drag a replicant into the deskbar, but cannot remove it.
Cannot right click, does the same as left clicking (does it 'disable' a CPU core? not sure of the effect :).

comment:2 Changed 4 years ago by umccullough

Shouldn't this be considered a bug?

comment:3 Changed 4 years ago by axeld

  • Type changed from enhancement to bug

Indeed.

comment:4 Changed 4 years ago by stpere

I could fix it quite easily, but it involves having the dragger icon into the green square. It's not really pretty but if nobody finds a better solution, I could submit the correction.

comment:5 Changed 4 years ago by humdinger

I have of course no idea how it's implemented and if my idea is at all possible...
Right now, the CPU buttons are exactly the size of the green buttons. Could their views be enlarged with a transparent background to have enough room for the Replicant dragger? Like this:

Now:  _______
      |     |
      |  1  |
      |_____|
             O
Then: _______
      |     |
      |  1  |
      |_____|
      |////O|

"O" being the dragger, "/" the transparent part of the enlarged view.

comment:6 Changed 4 years ago by stippi

Yes, this is possible now. One has to use code similar to ActivityMonitor or DeskCack in order for it to work.

comment:7 Changed 4 years ago by stpere

  • Owner changed from axeld to stpere
  • Status changed from new to in-progress

comment:8 Changed 4 years ago by stpere

  • Resolution set to fixed
  • Status changed from in-progress to closed

Hi, should be fixed in hrev35110. Comments welcome.

comment:9 follow-up: Changed 4 years ago by humdinger

Looks like you forgot to include string.h in CPUButton.h.
After replicating, the CPU number isn't quite centered in its button. I did like the former, smaller buttons better, but I'll get used to it. :) Thanks!

comment:10 follow-up: Changed 4 years ago by humdinger

Oh, and the About... menu of the Replicant says "CPUButton" instead of "Pulse". :)

comment:11 in reply to: ↑ 10 Changed 4 years ago by stpere

Replying to humdinger:

Oh, and the About... menu of the Replicant says "CPUButton" instead of "Pulse". :)

That point is fixed in hrev35116. Thanks!

comment:12 in reply to: ↑ 9 ; follow-up: Changed 4 years ago by stpere

Replying to humdinger:

Looks like you forgot to include string.h in CPUButton.h.
After replicating, the CPU number isn't quite centered in its button. I did like the former, smaller buttons better, but I'll get used to it. :) Thanks!

For the size of the replicant (when used on the desktop for example), I could make the dragger a little bit closer to the button, a bit like it is on deskcalc, where it overlaps the button's border.. do you think it would be better?

comment:13 in reply to: ↑ 12 Changed 4 years ago by humdinger

Replying to stpere:

For the size of the replicant (when used on the desktop for example), I could make the dragger a little bit closer to the button, a bit like it is on deskcalc, where it overlaps the button's border.. do you think it would be better?

The more compact it gets the better. But only if it isn't too much work. It's really only a small issue. You've fixed the important thing, having the Replicant removable. :)

comment:14 Changed 4 years ago by stpere

Could you try hrev35138? Thanks

comment:15 Changed 4 years ago by humdinger

Very nice! Thanks Philippe!

comment:16 Changed 2 years ago by rq

  • Resolution fixed deleted
  • Status changed from closed to reopened

It looks like this bug is valid again. I just dragged two replicants of CPU buttons into Deskbar, and cannot remove them now. I'm using hrev43238

comment:17 Changed 2 years ago by diver

  • Component changed from Applications to Applications/Pulse

comment:18 Changed 22 months ago by stpere

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in hrev44243.

Note: See TracTickets for help on using tickets.