Modifier+Click should not switch workspaces

[humdinger]

This is hrev32748.

Workspaces provides "special functionality", when left-clicking on a window-representation while holding a modifier key (CTRL, CTRL+SHIFT, OPT).

When you try to use it, however, it switches workspaces if you click into another workspace pane.

Holding one of those modifiers should disble workspace switching.

[anevilyak]

In that case I guess the ticket title should say "shouldn't switch"? Or am I misreading your detail description?

[humdinger]

Nitpicker. :)

[leavengood]

This should be pretty trivial to fix. I'll take ownership as I'm working on another Workspaces bug with a big patch (#8188) and therefore am learning the Workspaces code.

[leavengood]

OK this turned out to not be so trivial to fix, since the code which does this is in the app_server side of the WorkspacesView. In fact I've found an app_server bug while testing this, as well as general bugs in how this works. I'll keep working on it though and maybe can finish up tomorrow or this weekend.

[leavengood]

OK, so I fixed the other bug I found while testing this, and now I have a fix for this. But it turns out to have marginal utility. It really can only be used to minimize a window in another workspace.

Because Ctrl-Click activates the window, and activating a window will always switch to that workspace (which makes sense). And Opt-Click will move the window to the back, but that is ignored on workspaces which are not the current one, which I think makes sense too.

So maybe being able to minimize a window in another workspace with Ctrl-Shift-Click is useful enough to commit my fix? I'm not really sure which is why I'm asking.

[humdinger]

Replying to leavengood:

And Opt-Click will move the window to the back, but that is ignored on workspaces which are not the current one, which I think makes sense too.

Well, I could be useful to send windows on other workspaces to the back. For example, if you know the window you'd like to move to your current workspace is burried under other windows over there.

So maybe being able to minimize a window in another workspace with Ctrl-Shift-Click is useful enough to commit my fix? I'm not really sure which is why I'm asking.

It would help in the above scenario. OTOH, all these key-combos in Workspaces are pretty obscure. I doubt it's too widely used. It's maybe best not to assign too many resources to this. OTOH it seems to have revealed other bugs in the system, so no effort was "wasted"... :)