Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#4459 closed enhancement (fixed)

[patch] Implement reboot via ACPI

Reported by: VinDuv Owned by: axeld
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This patchs adds support for ACPI based reboot.
This is necessary on my MacBookPro, which is reluctant to both keyboard controller and triple fault-based reboot methods ;-)
BTW, Linux (2.6.30) suffers the same issue — it hangs after printing "machine restart" unless I add "reboot=pci" to the kernel arguments.

Attachments (1)

acpi_reboot.diff (2.6 KB ) - added by VinDuv 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by korli, 10 years ago

A few comments:

  • set_reset_register isn't a good name IMO, why not reboot?
  • an error message if the reset failed should be printed, one if the return status is different of OK, one in case of success after the snooze.
  • acpi_reboot and acpi_shutdown can probably be factorized

in reply to:  1 comment:2 by VinDuv, 10 years ago

Replying to korli:

A few comments:

  • set_reset_register isn't a good name IMO, why not reboot?

No reason ;) I was going to call it "reset", but thought it could be confusing. "reboot" is probably fine, though.

  • an error message if the reset failed should be printed, one if the return status is different of OK, one in case of success after the snooze.
  • acpi_reboot and acpi_shutdown can probably be factorized

Good point. New patch attached.

by VinDuv, 10 years ago

Attachment: acpi_reboot.diff added

comment:3 by korli, 10 years ago

Resolution: fixed
Status: newclosed

Edited and committed in hrev33135. Thanks!

comment:4 by korli, 10 years ago

I changed to use AcpiReset() in hrev34658. I hope it's still OK.

Note: See TracTickets for help on using tickets.