#4459 closed enhancement (fixed)
[patch] Implement reboot via ACPI
Reported by: | VinDuv | Owned by: | axeld |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | System/Kernel | Version: | R1/pre-alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
This patchs adds support for ACPI based reboot.
This is necessary on my MacBookPro, which is reluctant to both keyboard controller and triple fault-based reboot methods ;-)
BTW, Linux (2.6.30) suffers the same issue — it hangs after printing "machine restart" unless I add "reboot=pci" to the kernel arguments.
Attachments (1)
Change History (5)
follow-up: 2 comment:1 by , 15 years ago
comment:2 by , 15 years ago
Replying to korli:
A few comments:
- set_reset_register isn't a good name IMO, why not reboot?
No reason ;) I was going to call it "reset", but thought it could be confusing. "reboot" is probably fine, though.
- an error message if the reset failed should be printed, one if the return status is different of OK, one in case of success after the snooze.
- acpi_reboot and acpi_shutdown can probably be factorized
Good point. New patch attached.
by , 15 years ago
Attachment: | acpi_reboot.diff added |
---|
comment:3 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Edited and committed in hrev33135. Thanks!
Note:
See TracTickets
for help on using tickets.
A few comments: