Tracker's "Low Space" warning has bizarre criteria.

[dustin howett]

I notice, looking through the code, that Tracker only warns that a volume is running critically low on space if it's got <20 MB free AND that <20MB is <10% of the disk's capacity. I stumbled across this when I was looking at a volume (ext2) with 0.1% free disk space (about 100MB out of 100GB), and I considered this to be a very low disk space condition.

I've attached a (very simple) patch to rectify the situation (make the criteria a hard 9%-or-lower (<10%)), but might not fully understand the reasoning behind the original criteria.

[dustin howett]

Aforementioned patch.

[axeld]

It's been some time since I wrote this code, and the files were a lot smaller back then. The reason I limited that to 20 MB was that 20 MB was a lot of space 8 years ago - why should you be warned if you have that much space left? :-)

I am still a bit torn on this issue, though, as a percentage really doesn't make that much sense. If you have a 1 TB partition, it would already warn you when you still have 100 GB left - and that's still a lot of space these days. And that would make this warning pretty much meaningless - it should only warn you if the space is actually tight. 20 MB might not be adequate, anymore, though.

[waddlesplash]

Fixed in hrev50896. I went with 5%.