Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#46 closed bug (invalid)

ShowImage's slide show starts in the wrong folder

Reported by: jackburton Owned by: axeld
Priority: normal Milestone: R1
Component: Applications Version:
Keywords: Cc: diver
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Double click on a symlink (to an image), and then start the slide show: it'll show the images in the folder where the original linked image is, and not where the symlink is. Hope that was clear enough.

Change History (11)

comment:1 by johndrinkwater, 14 years ago

Should be able to fix that easily enough with an adjustment to ShowImageView::FindNextImageByDir() ? Just get it to traverse the entry_ref when it's agiven..

comment:2 by jackburton, 14 years ago

Looking at the code, I can't see how this bug can show up, as the entry_refs are never traversed, in any place.

comment:3 by jackburton, 14 years ago

Maybe I found the problem:

ShowImageView::FindNextImageByDir() uses GetNextRef() to get the next image to show. The bebook says about it:

"GetNextRef() return the next entry in ref. Since an entry_ref doesn't supply enough information to determine if the entry is a link, there's no question of traversal: The entry_ref points to exactly the next entry."

What does "The entry_ref points to exactly the next entry" mean ? It does always traverse or it does never traverse ? If it always traverse, that's the problem, and we should use GetNextEntry() instead.

comment:4 by jackburton, 14 years ago

Tracker resolve the link before sending the message to ShowImage (as verified by Korli), so we can't fix this bug within ShowImage.

comment:5 by axeld, 14 years ago

Owner: changed from sikosis to axeld

comment:6 by diver, 14 years ago

Cc: diver added

comment:7 by korli, 14 years ago

bug_group: developers

comment:8 by johndrinkwater, 14 years ago

Should this bug be labelled as invalid, or does Tracker passing a resolved symlink constitute a bug?

comment:9 by axeld, 13 years ago

Status: newclosed

comment:10 by axeld, 13 years ago

Resolution: wontfix

comment:11 by axeld, 13 years ago

We could experiment with Tracker, but I'm not sure yet if this improves or worsens the overall user experience. I'll close it for now.

Note: See TracTickets for help on using tickets.