Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#46 closed bug (invalid)

ShowImage's slide show starts in the wrong folder

Reported by: jackburton Owned by: axeld
Priority: normal Milestone: R1
Component: Applications Version:
Keywords: Cc: diver
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Double click on a symlink (to an image), and then start the slide show: it'll show the images in the folder where the original linked image is, and not where the symlink is. Hope that was clear enough.

Change History (11)

comment:1 Changed 14 years ago by johndrinkwater

Should be able to fix that easily enough with an adjustment to ShowImageView::FindNextImageByDir() ? Just get it to traverse the entry_ref when it's agiven..

comment:2 Changed 14 years ago by jackburton

Looking at the code, I can't see how this bug can show up, as the entry_refs are never traversed, in any place.

comment:3 Changed 14 years ago by jackburton

Maybe I found the problem:

ShowImageView::FindNextImageByDir() uses GetNextRef() to get the next image to show. The bebook says about it:

"GetNextRef() return the next entry in ref. Since an entry_ref doesn't supply enough information to determine if the entry is a link, there's no question of traversal: The entry_ref points to exactly the next entry."

What does "The entry_ref points to exactly the next entry" mean ? It does always traverse or it does never traverse ? If it always traverse, that's the problem, and we should use GetNextEntry() instead.

comment:4 Changed 14 years ago by jackburton

Tracker resolve the link before sending the message to ShowImage (as verified by Korli), so we can't fix this bug within ShowImage.

comment:5 Changed 13 years ago by axeld

Owner: changed from sikosis to axeld

comment:6 Changed 13 years ago by diver

Cc: diver added

comment:7 Changed 13 years ago by korli

bug_group: developers

comment:8 Changed 13 years ago by johndrinkwater

Should this bug be labelled as invalid, or does Tracker passing a resolved symlink constitute a bug?

comment:9 Changed 13 years ago by axeld

Status: newclosed

comment:10 Changed 13 years ago by axeld

Resolution: wontfix

comment:11 Changed 13 years ago by axeld

We could experiment with Tracker, but I'm not sure yet if this improves or worsens the overall user experience. I'll close it for now.

Note: See TracTickets for help on using tickets.