Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#4612 closed bug (invalid)

[Build System] HAIKU_INCLUDE_PATENTED_CODE doesn't work

Reported by: diver Owned by: bonefish
Priority: normal Milestone: R1
Component: Build System Version: R1/alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

I've added HAIKU_INCLUDE_PATENTED_CODE = 1 ; in my UserBuildConfig.
To be sure I removed old freetype objects
rm -rf generated/objects/haiku/x86/release/libs/freetype2
But Appearance still says that I have disabled anti-aliasing.

Change History (6)

comment:1 Changed 10 years ago by stippi

I think you have to remove the Appearance objects as well. Just do a "jam clean" if in doubt. That's how I tested this feature and I am pretty sure that it worked then. :-)

comment:2 Changed 10 years ago by diver

I've removed Appearance objects like this:

cd  haiku/trunk/src/preferences/appearance
jam clean

Rebuilt my image, but nothing changed, so I went ahead and commented out HAIKU_INCLUDE_PATENTED_CODE switch like this:

Index: headers/libs/freetype2/freetype/config/ftoption.h
===================================================================
--- headers/libs/freetype2/freetype/config/ftoption.h   (revision 33226)
+++ headers/libs/freetype2/freetype/config/ftoption.h   (working copy)
@@ -92,9 +92,9 @@
   /* This is done to allow FreeType clients to run unmodified, forcing     */
   /* them to display normal gray-level anti-aliased glyphs.                */
   /*                                                                       */
-#if HAIKU_INCLUDE_PATENTED_CODE
+//#if HAIKU_INCLUDE_PATENTED_CODE
 #      define FT_CONFIG_OPTION_SUBPIXEL_RENDERING
-#endif
+//#endif


   /*************************************************************************/
@@ -482,9 +482,9 @@
   /*   Do not #undef this macro here, since the build system might         */
   /*   define it for certain configurations only.                          */
   /*                                                                       */
-#if HAIKU_INCLUDE_PATENTED_CODE
+//#if HAIKU_INCLUDE_PATENTED_CODE
 #      define TT_CONFIG_OPTION_BYTECODE_INTERPRETER
-#endif
+//#endif

then I've removed Appearance objects again and now Appearance doesn't show that message.

comment:3 Changed 9 years ago by bonefish

Resolution: invalid
Status: newclosed

You can't set this variable in your UserBuildConfig. You have to use the configure option.

comment:4 Changed 9 years ago by diver

How should one run configure to enable it?

comment:5 Changed 9 years ago by mmadia

configure --include-patented-code <other configure options>

This and other options are mentioned in : configure --help

comment:6 Changed 9 years ago by diver

Thanks.

Note: See TracTickets for help on using tickets.