Hang at boot with updated ACPI module

[atomozero]

With this kernel config I can't boot:

acpi true
acpi_avoid_full_init true

I have tried with hrev33403 and I think the problem was introduced with the patch in hrev33236.

[mmlr]

I do also experience the hang at boot on my laptop since the update of the ACPI module. It's a HP/Compaq 2510p. I can get debug output as required.

[phoudoin]

What happen when you don't set acpi_avoid_full_init to true, aka when you allow full ACPI init?

Before hrev33236, ACPI was not in a better shape but was, in fact, safer because its initialisation was half done, stopping a lot of non/bad-implemented feature to crash.

[jackburton]

I have the same problem on my laptop (Fujitsu-siemens Amilo li2735). With or without the acpi_avoid_full_init.

[tqh]

Hanging that late is probably not the ACPI impl itself (it did pass ACPI init and is in ACPI mode). It's most likely one of the ACPI drivers, probably ACPI Embedded Controller. Try removing it when booting with ACPI disabled and see if it boots to desktop.

(ACPI init is done under the third icon)

[tqh]

Fixed global locking code, base on FreeBSD's

[tqh]

I think the attached patch should fix this as I had, and was working on tracking the same issue on my laptop. For me it turned out that the global locking code was broken, and all my systems can now fully run under ACPI.

(Some additional code is in the patch, but IMO that should be updated as well.) FreeBSD impl can be viewed here: ​http://fxr.watson.org/fxr/source/dev/acpica/Osd/OsdSynch.c#L581

[tqh]

At least one person has confirmed this patch to fix the hang for them, more feedback welcome. Also I think it should be possible to commit it (pls review first).

[phoudoin]

I'll test your patch ASAP and if it does fix it, as I believe it will, I'll do the commit.

[tangobravo]

The patch fixes my laptop's AHCI hang. Does a full init now, and PowerStatus works. No CPUFrequency info though. syslog attached if anyone's interested.

[tangobravo]

syslog after working boot with patch - thanks tqh!

[tqh]

That syslog can't be right:

KERN: acpi: ACPI disabled

[tqh]

nvm, it contained several boots.

[tqh]

The check in AcpiOsWritable should probably be:

	return (info.protection & B_READ_AREA) &&
			(info.protection & B_WRITE_AREA) && 
			(pointer + length) <= (info.address + info.ram_size);

[phoudoin]

Patch applied in hrev33781.

[jackburton]

with hrev33781 my laptop doesn't hang at boot anymore with ACPI enabled, and it also shuts down correctly. Nice work tqh! Bug closed for me.

[phoudoin]

Indeed. And +1 for tqh thanking. BTW tqh, do you ask commit access already?

[tqh]

No I havn't, but it would simplify things for me.

[atomozero]

Replying to phoudoin:

Indeed. And +1 for tqh thanking.

thx tqh and thx phoudoin :)

[phoudoin]

Replying to tqh:

No I havn't, but it would simplify things for me.

I've just call a vote for it on haiku-development.

[axeld]

Replying to tqh:

The check in AcpiOsWritable should probably be:

	return (info.protection & B_READ_AREA) &&
			(info.protection & B_WRITE_AREA) && 
			(pointer + length) <= (info.address + info.ram_size);

Besides the coding style issues, I'm not sure if that's what you mean. B_READ_AREA means readable from userland. Likewise, B_WRITE_AREA means writable from userland as well.

[tqh]

I think that is mostly for userland, it wasn't really supposed to be part of the patch. It was however better than what was in svn so to test if it fixed hang for others I let it be there. Just wanted to mention it's not correct.

[tqh]

acpica can be used to build a lot of acpi tools as well. I just implemented most of the functions to make sure those weren't problems.