Opened 15 years ago
Closed 14 years ago
#4789 closed bug (fixed)
Draft mail doesn't remember the From account
Reported by: | humdinger | Owned by: | phoudoin |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Applications/Mail | Version: | R1/Development |
Keywords: | gsoc2011 | Cc: | jalopeura@… |
Blocked By: | Blocking: | ||
Platform: | All |
Description
This is hrev33529.
When opening a saved draft mail, the From field always uses the default mail account. Instead the account that's been set for the mail when it was saved should be remembered.
Attachments (1)
Change History (10)
comment:1 by , 14 years ago
patch: | 0 → 1 |
---|
comment:2 by , 14 years ago
comment:3 by , 14 years ago
Keywords: | gsoc2011 added |
---|
comment:4 by , 14 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
What will happens if the account at draft save time don't exists anymore now (or was renamed)? Same goes for encoding, even if it's a lesser risk.
In such case, account or encoding should bet set to default one. And no need to put in comment previous code.
Correct these issues, and I'll be glad to commit your patch.
comment:5 by , 14 years ago
Hm.
It looks like BMenu::FindItem() will return NULL...which will cause a problem.
I left the commented code in because I wasn't sure which version was the preferred style. Now I need to use it anyway, so I can check for NULL.
I'm in the middle of something on Windows at the moment; expect an updated patch in a few hours.
comment:6 by , 14 years ago
Okay, fixed the problem with my last patch. I verified by manually changing the account and encoding attributes to "none", and it worked.
I also noticed that changing the account and/or encoding doesn't mark the mail as changed (i.e., doesn't enable the Save button), so I fixed that as well.
comment:7 by , 14 years ago
Cc: | added |
---|
comment:9 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Applied in hrev41266. Thanks.
This patch fixes it so the drafts now remember the account, and the encoding as well.