Opened 10 years ago

Closed 9 years ago

#4789 closed bug (fixed)

Draft mail doesn't remember the From account

Reported by: humdinger Owned by: phoudoin
Priority: normal Milestone: R1
Component: Applications/Mail Version: R1/Development
Keywords: gsoc2011 Cc: jalopeura@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is hrev33529.

When opening a saved draft mail, the From field always uses the default mail account. Instead the account that's been set for the mail when it was saved should be remembered.

Attachments (1)

maildiff2.txt (2.8 KB ) - added by jalopeura 9 years ago.
Patch

Download all attachments as: .zip

Change History (10)

comment:1 by jalopeura, 9 years ago

Has a Patch: set

comment:2 by jalopeura, 9 years ago

This patch fixes it so the drafts now remember the account, and the encoding as well.

comment:3 by jalopeura, 9 years ago

Keywords: gsoc2011 added

comment:4 by phoudoin, 9 years ago

Owner: changed from bga to phoudoin
Status: newassigned

What will happens if the account at draft save time don't exists anymore now (or was renamed)? Same goes for encoding, even if it's a lesser risk.

In such case, account or encoding should bet set to default one. And no need to put in comment previous code.

Correct these issues, and I'll be glad to commit your patch.

Last edited 9 years ago by phoudoin (previous) (diff)

comment:5 by jalopeura, 9 years ago

Hm.

It looks like BMenu::FindItem() will return NULL...which will cause a problem.

I left the commented code in because I wasn't sure which version was the preferred style. Now I need to use it anyway, so I can check for NULL.

I'm in the middle of something on Windows at the moment; expect an updated patch in a few hours.

by jalopeura, 9 years ago

Attachment: maildiff2.txt added

Patch

comment:6 by jalopeura, 9 years ago

Okay, fixed the problem with my last patch. I verified by manually changing the account and encoding attributes to "none", and it worked.

I also noticed that changing the account and/or encoding doesn't mark the mail as changed (i.e., doesn't enable the Save button), so I fixed that as well.

comment:7 by jalopeura, 9 years ago

Cc: jalopeura@… added

comment:8 by phoudoin, 9 years ago

Thanks, looks fine now. I'll commit it soon.

comment:9 by phoudoin, 9 years ago

Resolution: fixed
Status: assignedclosed

Applied in hrev41266. Thanks.

Note: See TracTickets for help on using tickets.