Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#4830 closed enhancement (invalid)

"Expand New Applications" not always practical

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: R1
Component: Applications/Deskbar Version: R1/Development
Keywords: Cc: stippi
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is hrev33708.

Even though the options "Show Application Expander" and "Expand New Applications" are activated, after boot-up the Tracker entry is always collapsed.
The auto-launched LaunchPad, however, is expanded. This is because Tracker is started earlier than the Deskbar and thus isn't considered a "New Application".

You can see the same behaviour, when you have a couple of running apps, all expanded, and then quit the Deskbar via ProcessController. Upon Deskbar restart, every app is collapsed.

Now, does it really make sense to just "Expand *New* Applications" or would it be more practical to have the setting to just "Expand Applications"? I think the latter.

Attachments (2)

Deskbar Autoexpand 1.diff (8.8 KB ) - added by jscipione 9 years ago.
Changed "Expand New Applications" to "Auto-expand applications" and made it work. This patch is for "viewing only" for now until my patch in ticket #7052 gets committed since both this patch and that patch touch ChangeState() in different ways, so if you apply both patches you'll get a conflict. Other than that, this patch can be applied and will allow you to test the feature. When the checkbox is checked all applications are expanded, new ones get expanded too. Unchecking will unexpand all applications. You can expand and unexpand apps at will but they each "start" expanded.
Deskbar Autoexpand 2.diff (9.4 KB ) - added by jscipione 9 years ago.
Slightly updated patch that calls UpdatePlacement when a new team gets launched so that it will get automatically expanded.

Download all attachments as: .zip

Change History (9)

comment:1 by axeld, 10 years ago

Owner: changed from axeld to nobody

comment:2 by jscipione, 9 years ago

I experimented with changing "Expand New Applications" to "Expand All Applications" and created a function in BarView.cpp that would do just that. It works great, when you check the option it expands all your applications and when you un-check it, it un-expands all your applications. I call the function from ChangeState() so that when new applications get launched they also get expanded. The problem I am having is that on reboot the Deskbar tries to expand Tracker (which it can do since you might have open Tracker windows on boot) and somewhere in the ToggleExpandedState() function Deskbar crashes. I think a better name for this would be "Auto-expand Applications" since you can selectively un-expand apps using the up/down arrow. I'll submit a patch as soon as I track down what is causing Deskbar to crash on boot.

by jscipione, 9 years ago

Attachment: Deskbar Autoexpand 1.diff added

Changed "Expand New Applications" to "Auto-expand applications" and made it work. This patch is for "viewing only" for now until my patch in ticket #7052 gets committed since both this patch and that patch touch ChangeState() in different ways, so if you apply both patches you'll get a conflict. Other than that, this patch can be applied and will allow you to test the feature. When the checkbox is checked all applications are expanded, new ones get expanded too. Unchecking will unexpand all applications. You can expand and unexpand apps at will but they each "start" expanded.

comment:3 by jscipione, 9 years ago

Has a Patch: set

I meant ticket #7051 not #7052

Last edited 9 years ago by jscipione (previous) (diff)

by jscipione, 9 years ago

Attachment: Deskbar Autoexpand 2.diff added

Slightly updated patch that calls UpdatePlacement when a new team gets launched so that it will get automatically expanded.

comment:4 by diver, 8 years ago

Cc: stippi added

Would be nice if someone (hint hint) could look into this.

comment:5 by jscipione, 8 years ago

The patches attached to this ticket are no longer relevant. Instead see the patches on #7051 which fixes this bug along with another bug. The patch on #7051 fixes the original bug of launching "new" applications not always working, such as Tracker on startup, rather than trying to re-purpose the checkbox to expand all applications. If you restart Deskbar all applications are considered "new" so they all get expanded.

comment:6 by nielx, 8 years ago

Resolution: invalid
Status: newclosed

See comment:5

comment:7 by jscipione, 8 years ago

Fixed in hrev43092

Note: See TracTickets for help on using tickets.