Opened 9 years ago

Last modified 4 years ago

#4916 assigned enhancement

Configuring Favorites (easy)

Reported by: humdinger Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/libtracker.so Version: R1/Development
Keywords: Cc:
Blocked By: #5090 Blocking:
Has a Patch: no Platform: All

Description

This is hrev33939.

Choosing "Favorites | Configure Favorites..." from an Open/Save panel opens a special panel similar what was available for configuring the Deskbar's ~/config/be/ menu in the past. As with the Deskbar, the favorite menu should be rename "Favorites | Edit Favorites..." and simply open ~/config/settings/Tracker/Go/.

Also, once Favorites are available, the heading in the Open/Save panel Favorites-menu shouldn't be "Favorite Folders", but simply "Favorites", because those can also be mere files.

Change History (12)

comment:1 Changed 9 years ago by axeld

Component: Kits/Interface KitKits/libtracker.so
Owner: changed from axeld to anevilyak

Not obvious, but that part lives in libtracker.so :-)

comment:2 Changed 9 years ago by anevilyak

One question I have here: how does it make sense to have a favorite that's a file? Generally speaking they're intended for quickly navigating to commonly used locations, and a non-folder type really doesn't make sense in that context, with the possible exception of a symlink, which would just be a special case of a folder.

comment:3 Changed 9 years ago by humdinger

As Favorites are also present in Open panels, it can make sense. Maybe for some form of template document you regularly use.

comment:4 Changed 9 years ago by anevilyak

In that case, I'd like to make two amendments here: 1) In the case of a save panel, keep it as "Favorite Folders" and filter out anything that's not a folder or symlink to a folder, and 2) In the case of an open panel, the favorites entries need to be run through any ref filters the hosting app has attached (i.e. to filter out any file types the app can't handle). Thoughts?

comment:5 Changed 9 years ago by humdinger

Sounds even better, though for consistency's sake, I'd leave the label as the more general "Favorites" instead of in one case "Favorite Folders". It's enough to filter out non-folders in that case, and the folders that remain after that are still "Favorites".

comment:6 Changed 9 years ago by anevilyak

Status: newassigned

Fair enough, we'll go with that then.

comment:7 Changed 9 years ago by anevilyak

Implemented in hrev34071, with the exception of the ref filtering (will hopefully have that done tomorrow night).

comment:8 Changed 9 years ago by anevilyak

Ref filtering implemented in hrev34190, just needs to retrieve Deskbar's settings for recent counts and add those to the menu now.

comment:9 Changed 9 years ago by anevilyak

Blocked By: 5090 added

comment:10 Changed 6 years ago by anevilyak

Owner: changed from anevilyak to nobody
Status: in-progressassigned

Not currently working on this.

comment:11 Changed 5 years ago by rexmorgan

Is there still work to do with this ticket? Looks like hrev34071 and hrev34190 took care of it, can it be closed?

Also, is #5090 still blocking this?

comment:12 Changed 4 years ago by waddlesplash

Milestone: R1Unscheduled

Moving libtracker.so enhancement tickets out of R1 milestone -- Tracker's source code comes from BeOS R5, so it already has all the features it did on R5.

Note: See TracTickets for help on using tickets.