Opened 9 years ago

Last modified 4 years ago

#5090 assigned enhancement

Deskbar/Tracker favorites refactoring

Reported by: anevilyak Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/libtracker.so Version: R1/alpha1
Keywords: Cc:
Blocked By: Blocking: #4916
Has a Patch: no Platform: All

Description

Deskbar and Tracker both have their own favorites menu subclasses instead of sharing code. This should be refactored a bit in order to make the settings be shared in a common place (libtracker) and clean up the code a bit. Also, care should be taken to not lose features in the process ; Deskbar's version of the favorites menu will spawn submenus showing the recent documents associated with a specific app. This should be folded into the class the two ultimately wind up sharing.

Note for future - It would be nice for Launchbox to have similar functionality, though that probably also deserves its own ticket.

Change History (6)

comment:1 Changed 5 years ago by rexmorgan

Does this refactoring still need to happen (it's been open for 4 years)? Also, could you list the separate classes that need to be combined? That would make it a little easier for someone else to pick this ticket up.

comment:2 Changed 5 years ago by rexmorgan

I started looking into this refactoring, but I wasn't able to find a favorites menu class in the Deskbar application source. I also searched for it within the application itself and couldn't find a place where you could select your favorite folder.

comment:3 Changed 5 years ago by humdinger

There isn't yet a "Favorites" in Deskbar (no idea about the code, just talking about the app/concept itself). There should be, however, maybe above the "Recent documents/folders/applications" items. It should share the contents of ~/config/settings/Tracker/Go/ and should get a checkbox to hide/show it in the Deskbar prefs under "Menu".

AnEvilYak points out (I think), that this new "Favorites" menu should also have the ability to have subfolders that work like in the "Recent" folders. So the Recent and the Favorites code should be kinda unified.

comment:4 Changed 5 years ago by rexmorgan

Just to be sure this ticket is clear, this isn't about merging two classes that access favorites, it's about adding a feature to view favorites from within the Deskbar and making sure that Tracker and Deskbar share the same code to retrieve those favorite folders.

If the concept of favorite folders is not exclusive to Tracker, should the location of these favorite folders be something different and more system generic than ~/configs/settings/Tracker/Go/?

Also, if Tracker and Deskbar are both working with these favorite folders, should this feature be in some shared location?

Sorry if these questions make it seem like amateur hour in here, I'm not familiar with the source, or BeOS in general.

comment:5 Changed 4 years ago by anevilyak

Owner: changed from anevilyak to nobody
Status: newassigned

comment:6 Changed 4 years ago by waddlesplash

Milestone: R1Unscheduled

Moving libtracker.so enhancement tickets out of R1 milestone -- Tracker's source code comes from BeOS R5, so it already has all the features it did on R5.

Note: See TracTickets for help on using tickets.