Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#5066 closed enhancement (fixed)

ALI 5451 audio driver

Reported by: bmkx Owned by: korli
Priority: normal Milestone:
Component: Drivers/Audio/sis7018 Version: R1/alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Attached an archive containing driver for ALI M5451 audio chip for new multi audio.

Attachments (3)

ali5451.zip (21.8 KB) - added by bmkx 9 years ago.
ali 5451 audio driver
ali5451_091203.patch (10.5 KB) - added by bmkx 9 years ago.
Switching to use ac97 common code module.
ac97_add_hp_nc.patch (543 bytes) - added by bmkx 9 years ago.
Enable headphone jack sense for HP NC 40xx notebooks.

Download all attachments as: .zip

Change History (14)

Changed 9 years ago by bmkx

Attachment: ali5451.zip added

ali 5451 audio driver

comment:1 Changed 9 years ago by mmadia

Nice! Typically, the developers don't like zipped attachments. Would you create a patch for these files instead? In the HAIKU_TOP directory, you could use

svn add src/add-ons/kernel/drivers/audio/ali5451
svn diff src/add-ons/kernel/drivers/audio/ali5451 > ~/driver-ali5451.patch

and congrats on your first contribution!

comment:2 Changed 9 years ago by bipolar

Maybe this could also work for the SiS 7018 and Trident DX/NX cards? (like Siarzhuk Zharski's legacy audio driver?).

comment:3 in reply to:  1 Changed 9 years ago by korli

Replying to mmadia:

Nice! Typically, the developers don't like zipped attachments. Would you create a patch for these files instead? In the HAIKU_TOP directory, you could use

No, the package is fine as is for addition.

comment:4 Changed 9 years ago by korli

Status: newassigned

comment:5 in reply to:  2 ; Changed 9 years ago by bmkx

Replying to bipolar:

Maybe this could also work for the SiS 7018 and Trident DX/NX cards? (like Siarzhuk Zharski's legacy audio driver?).

Yes, those are similar, but there are some differences. In fact I used Trident's documentation to some degree, because of lack of documentation for ALI. I'll look into that, but then I'd need some assistance in testing/debugging :)

comment:6 in reply to:  5 Changed 9 years ago by siarzhuk

Replying to bmkx:

Replying to bipolar:

Maybe this could also work for the SiS 7018 and Trident DX/NX cards? (like Siarzhuk Zharski's legacy audio driver?).

Yes, those are similar, but there are some differences. In fact I used Trident's documentation to some degree, because of lack of documentation for ALI. I'll look into that, but then I'd need some assistance in testing/debugging :)

My sis7018 is not abandoned - it is just pending behind other. :-( I have hacked my sources for sis7018 some months ago, but the code is still far away from perfection and need polishing for other chip types. It is available here: http://siarzhuk.dyndns.org/viewvc/viewvc.cgi/cvsroot/sis7018/ Anyway it already works well for my sis7018 hardware.

Other difference is coding style - my drivers use c++ instead of c.

comment:7 Changed 9 years ago by korli

Committed in hrev34452. Just one thing: Would it be possible to reuse the ac97 common code instead of the home brewed code ?

comment:8 in reply to:  7 Changed 9 years ago by siarzhuk

Replying to korli:

Committed in hrev34452. Just one thing: Would it be possible to reuse the ac97 common code instead of the home brewed code ?

Do we have plans to "module-arize" AC97 common code in the future? ;-)

comment:9 in reply to:  7 Changed 9 years ago by bmkx

Replying to korli:

Committed in hrev34452. Just one thing: Would it be possible to reuse the ac97 common code instead of the home brewed code ?

Yeah, I'll do it.

Changed 9 years ago by bmkx

Attachment: ali5451_091203.patch added

Switching to use ac97 common code module.

Changed 9 years ago by bmkx

Attachment: ac97_add_hp_nc.patch added

Enable headphone jack sense for HP NC 40xx notebooks.

comment:10 Changed 9 years ago by korli

Resolution: fixed
Status: assignedclosed

Thanks! Applied in hrev34484 and hrev34485.

comment:11 Changed 8 years ago by diver

Component: Drivers/AudioDrivers/Audio/sis7018
Platform: x86All
Note: See TracTickets for help on using tickets.