[ScreenSaver] Many stability issues and other problems

[diver]

I will attach my screensaver collection (115 items -2,4Mb) which i used for testing Haiku's ScreenSavers. Good news is that most of them (~100) seems to work, didn't test them in fullscreen mode though. Here are what i've found for the rest of them:

*1. I've started ScreenSaver from Terminal and on every ssaver selection i got

"runtime_loader: cannot open file /boot/beos/system/add-ons/Screen

Savers/<screensaver_name>".

Tip: open ~/config/settings window to delete screensaver_settings file when ScreenSaver start to crash on start. I think this is something to work out too.

*2. This screensavers will crash ScreenSaver pref: DS_Wobble: Segment violation KanjiSaver: Segment violation LicenseBreaker: Segment violation MeltdownBlur: Trying to delete a view that belongs to a window.Call RemoveSelf first. PrimalVision: Trying to delete a view that belongs to a window.Call RemoveSelf first. Roto_saver: elf_resolve_symbol: could not resolve symbol SetiSaver: Segment violation Sphere: Segment violation ZeroWing: addon_file ain't readable. darn! ChaoticLine: have some problems too, don't remember. Samhain: will freeze ScreenSaver. MapSaver: !!!Haiku will reboot!!! BrainWash: !!!Haiku will became black&white!!! IdleMind: ScreenSaver will close.

*3. Screensavers are wrongly sorted in the end of that list. *4. Almost all ssaver have font sensitive issues. (e.g. Nebula ;-) ) *5. ScreenSaver itself isn't font sensetive. *6. Running almost every screensaver in fullscreen will not let you out. You have to switch to another workspace and kill screen_blanker. (test case: Nebula) *7. After you killed screen_blanker in #6 via team monitor switch to first workspace, team monitor will be behind ScreenSaver pref. *8. If you have this savers installed and delete ScreenSaver_settings, after ScreenSaver start it will not select 1st module, but 6th or 7th instead. *9. Module listview need to prettfy.

All in all this is collection is a good stress tests for haiku, which should show it week sides. If there is a need, i could attach back traces for every crashing module.

[diver]

screensaver collection part 1

[diver]

screensaver collection part 2

[diver]

screensaver collection part 3 (last)

[diver]

Some problems went away and some new problems appears. 80% of ssavers will not work without libnet.so, so i made up a link to libnetwork.so to make them work. Very often after screen_blanker crash, app_server will deadlock too. Sometimes when screensaver pref crashes and then you close debug window frozen screensaver will stay on screen until i kill gdb from processcontroller. If you select first ssaver and then hold down down arrow you will crash ScreenSaver.

All in all there is a big troubles with screensavers, so it would be nice if you could have a look at those, Axel!

[diver]

If after screen_blanker crash you will quickly press ok in crash window app_server will not die!

[jackburton]

Diver, can you recheck after hrev19891 ?

[diver]

screen_blanker don't crash anymore and app_server crashed only once with bt from #634. So now ScreenSaver will crash or hang or just will not load a saver. Also some savers doesn't work in fullscreen mode, while in prview mode thay are ok. Ah and annoying slow selection of savers should be avoided if possible.

[kaoutsis]

The file 'Fetcher' included in ScreenSaver_2.zip doen't appear to be a valid screensaver, or it's corrupted; i tested also on hrev5, it doesn't do anything in preview mode (selecting Fetcher the test button is disabled), and if i insist selected it as screensaver, ScreenSaver pref. just ignore it. On Haiku crashes the ScreenSaver pref. if selected.

[aldeck]

Diver, can you recheck? At least some crashes could have been fixed with hrev25761 . I'll have a look at the remaining problems. Thanks!

[diver]

*1. Fixed. *2. Trouble screensavers

DS_Wobble: works now PrimalVision: works now Roto_saver: works now ChaoticLine: works now Samhain: works now

MapSaver: don't crash anymore but doesn't work SetiSaver: don't crash anymore but doesn't work KanjiSaver: don't crash anymore, but doesn't work.

LicenseBreaker: screen_blanker crash, see LicenseBreaker.png MeltdownBlur: If you press Test it will change resolution to lowest, then screen_blanker will crash, back trace is the same as LicenseBreaker.png Sphere: Segment violation. See Sphere.png ZeroWing: addon_file ain't readable. darn! BrainWash: Running in VirtualBox will crash versa.accelerant. see BrainWash.png for backtrace IdleMind: ScreenSaver will close, but left in Deskbar

*3. Fixed *4. Invalid. *5. Fixed. *6. Fixed. *7. Probably fixed. *8. Fixed. *9. Module listview need some offset to be more pretty. But this is not belong to this bug.

[diver]

Please someone fix formatting in description and in my comment 7.

I would recommend to close this bug as fixed as most of the bugs are fixed now.

After that I will open new tickets about remaining bugs.

[diver]

Any opinions on these?

[diver]

ping!

[axeld]

Just let me look into it before I say anything - may take a while, but it's on my list. Please schedule your next nagging in about 3 month ;-)

[axeld]

Just looked into BrainWash, and fixed a bug in BWindowScreen that prevented those from working. However, it still doesn't seem to work. Feel free to do as you suggested :-)

[jscipione]

Ball Saver crash

[jscipione]

Ball saver crash (last one was actually 3dmorph)

[jscipione]

BeSwarm crash report

[jscipione]

Binary Clock crash report

[jscipione]

BSOD for BeOS R5

[jscipione]

cell_screen crash report

[jscipione]

CubeSaver crash report

[jscipione]

FlipSaver crash report

[jscipione]

Flurry crash report

[jscipione]

GLCubes crash report

[jscipione]

GLife crash report

[jscipione]

License Breaker crash report

[jscipione]

I have more but I think you get the idea, a couple of screensavers crash the OS including MapSaver making debugging difficult. Others simply don't work but don't crash. Many have layout issues but that is expected.

[jscipione]

Sorry the crash report descriptions don't match the reports because I reversed the order of them, but you can gleam what goes with what from the report descriptions

[jscipione]

3dMorph - crashes AnalogClockSaver - works Atari Memory Test - works, no preview AttackoftheKillerBAlerts - works, no preview, font issues in settings BackgroundSaver - works Ball - works band - works BeBubbles - works BePyro - works, font issues in settings BeSwarm - crashes BeWake - works Bin95 - works, font issues in settings BinaryClock - crashes screen_blanker, settings messed up, previews OK Brainwash - changes screen resolution to 640x480, can't stop, have to reboot BSOD for BeOS R5 - crashes CBScreenSaver - works, settings messed up cell_screen - works ChaoticLine - works Circles - works, settings cut off CL-Amp - works ClockSaver - works, settings cut off Clozer - blank, settings cut off CubeSaver - doesn't load, crashes on exit CubeSaverTwo - doesn't load, crashes on exit DecayScreen - works, no preview Deco - works Distort - works but crashes on preferences changes DrunkVision - crashes DS_Wobble - crashes DuckSaver - doesn't load, casualty of PM FadePlot - works Fetcher - crashes Flash Player - crashes FlipSaver - works Forest - works FracTri - works FSOv1.1 - could not load, crashes on exit Funky Spots - works, settings messed up GalaxyScreenSaver - works Geometric Dreams - works George Fox Epistle 46 - works GLCubes - could not load, crashes on exit GLCubes2 - could not load, crashes on exit GLife - works but crashes on exit, we have an updated version in tree Gradient - works, settings cut off Hate(1) - works, settings messed up Holiday - works HopalogSaver - works IdleMind - quits window Interfade - works K.I.T.T - works, settings cut off, no preview Kablooie, works KanjiSaver - works Kernel - works Konfetti - works Latenight1 - works License Breaker - crashes MapSaver - doesn't load Matrix - works MatricCode - works, settings cut off Meltdown Blur - quits window Moire - works moreofthebuggers - crashes Mountain - works MySpots - works, settings cut off nausea - works Nebula - works, settings overlap OpenBeOS - works, settings cut off Orbit - could not load saver, crashes on exit Particle - works PentoSaver - works Ping - works, settings cut off Plasma - works, settings cut off PrialVision - works pushpin - works Puzzle - works Pyro - works RandomSaver - crashes on exit Rorschach - works Rosettes - works Rstarts - works, settings cut off Samhain - works Scooter - works SETISaver - quits window SheepSaver - doesn't load, another victim of PM shifter - works Shoots - works Sierpinski - works SlideshoSaver - works, settings overlap Slizer - works Snow - works, settings cut off Sonar - works, settings cut off Space - works, font issues in settings Sparticles - works Spider - works Spirilla - works Spots & More 1.0 - works, font and layout issues in settings Star Saver, works, no preview SuckSaver, works SuperCircles, works, font issues in settings, appears to be same as BeBubbles SuperSpots, works, settings cut off Terazzo, works TextCrawler - works TextFader - works The Hole - crashes The UnNamedOne - crashes TileSaver - works Vines - works Wolle - works, text cut off in settings XJack - works XRoger - crashes ZeroWing - works Zoom - works

[pulkomandy]

I'm sure I had 3DMorph running, like, last year.

Anyway, what's the point of reopening this very old bug for probably unrelated crashes? I'd rather have a new bug (or maybe several ones) with one different problem at a time (compare the stacktraces). For example, I know BrainWash isn't running anymore, but that's because of a race condition in BDirectWindow initialisation, which doesn't even belong in screensaver kit...

[jscipione]

Replying to pulkomandy:

I'm sure I had 3DMorph running, like, last year.

Anyway, what's the point of reopening this very old bug for probably unrelated crashes? I'd rather have a new bug (or maybe several ones) with one different problem at a time (compare the stacktraces). For example, I know BrainWash isn't running anymore, but that's because of a race condition in BDirectWindow initialisation, which doesn't even belong in screensaver kit...

Be careful what you wish for. :)

[waddlesplash]

There have been a lot of cleanups lately. Can this be closed?

[jscipione]

#10581 is not blocked by this since the issue is not related to screen savers

[diver]

This is a crash in Flash Player screensaver in SetDefaultSWF. So it's likely it's just a bug in this screensaver.

[Saqlain5442]

I have tested them.On full-screen some of the are black screen with no screen saver.

[Saqlain5442]

Table
Screen saver	works or not
3dMorph	crashes
AnalogClockSaver	works
Atari Memory Test	works
AttackoftheKillerBAlerts	works
BackgroundSaver	works
Ball	works
band	works
BeBubbles	works
BePyro	works
BeSwarm	works
BeWake	works
Bin95	works
BinaryClock	works
Brainwash	works but can't stop it
BSOD for BeOS R5	works
CBScreenSaver	works
cell_screen	works
ChaoticLine	works
Circles	works
CL	Amp	works
ClockSaver	works
Clozer	blank
CubeSaver	doesn't load
CubeSaverTwo	doesn't load
DecayScreen	works
Deco	works
Distort	works
DrunkVision	works
DS_Wobble	work
DuckSaver	doesn't load
FadePlot	works
Fetcher	works
Flash Player	crashes
FlipSaver	works
Forest	works
FracTri	works
FSOv1.1	could not load
Funky Spots	works
GalaxyScreenSaver	works
Geometric Dreams	works
George Fox Epistle 46	works
GLCubes	works
GLCubes2	could not load
GLife	works
Gradient	works
Hate(1)	works
Holiday	works
HopalogSaver	works
IdleMind	quits window
Interfade	works
K.I.T.T	works
Kablooie	works
KanjiSaver	works
Kernel	works
Konfetti	works
Latenight1	works
License Breaker	works
MapSaver	doesn't load
Matrix	works
MatricCode	works
Meltdown Blur	works
Moire	works
moreofthebuggers
Mountain	works
MySpots	works
nausea	works
Nebula	works
OpenBeOS	works
Orbit	could not load saver
Particle	works
PentoSaver	works
Ping	works
Plasma	works
PrialVision	works
pushpin	works
Puzzle	works
Pyro	works
RandomSaver	works
Rorschach	works
Rosettes	works
Rstarts	works
Samhain	works
Scooter	works
SETISaver	quits window
SheepSaver	doesn't load
shifter	works
Shoots	works
Sierpinski	works
SlideshoSaver	works, settings overlap
Slizer	works
Snow	works, settings cut off
Sonar	works
Space	works
Sparticles	works
Spider	works
Spirilla	works
Spots & More 1.0	works
Star Saver	works
SuckSaver	works
SuperCircles	works
SuperSpots	works
Terazzo	works
TextCrawler	works
TextFader	works
The Hole	crashes
The UnNamedOne	works
TileSaver	works
Vines	works
Wolle	works
XJack	works
XRoger	crashes
ZeroWing	works
Zoom	works

[Saqlain5442]

This reportfile is from screen saver Flash Player.

[cocobean]

Tested with Haiku hrev52031 x86.

NOTE: DuckSaver works. Use the DuckSaver package in Haiku Depot. Working screensavers may also live in something like the ​http://clasquin-johnson.co.za/michel/repo/packages/beos_screensaver_collection-1.0-14-x86_gcc2.hpkg, although I created a custom hpkg test package for testing based on the included packages attached to this ticket.

Screensaver	works or not	beos_screensaver_collection-1.0
BrainWash	works, doesn't exit cleanly	not in package
Clozer	blank	not in package
CubeSaverTwo	doesn't load	not in package
Flash Player	crashes	not in package
IdleMind	quits window	not in package
MapSaver	missing files, doesn't load	not in package
SETISaver	blank	not in package
SheepSaver	doesn't load, no resource file	not in package
ZeroWing	crashes	works in package

I can suggest closing this ticket as these remaining screensavers were either removed from the tested beos_screensaver_collection-1.0 package or fixed in the package (i.e. ZeroWing). They require additional files or proper porting which are optional at this time.

[jscipione]

The BeOS DuckSaver program found here: ​http://maybe.de/software/ducksaver/ doesn't work right on Haiku because it hard codes the directory to look for its assets (/boot/home/config/add-ons/Screen Savers/DuckSaver/) and that directory no longer exists on PM Haiku. The version on HaikuArchives ​https://github.com/HaikuArchives/DuckSaver uses a method only available on Haiku (Resources SetToImage) to find the assets without hardcoding directory paths so it should work fine on Haiku (but not on BeOS). ​https://www.haiku-os.org/docs/api/classBResources.html#a7134ad1f4514b6b5546957aade7ca77a