[Patch] Applying BGridLayout to Terminal preference

[mt]

Applying BGridLayout to BMenuFields in AppearPrefView.cpp.

[mt]

patch file

[stippi]

Patch looks good to me, thanks for the cleanup as well! Note that the -> operators would go on the next line. I usually break up these lines with an open parenthesis. So instead of

    fFont->Menu()->
        FindItem(PrefHandler::Default()->
        getString(PREF_HALF_FONT_FAMILY))->SetMarked(true);

I would do:

    fFont->Menu()->FindItem(PrefHandler::Default()->getString(
        PREF_HALF_FONT_FAMILY))->SetMarked(true);

(Your version does have it's appeal because of clarity, but the other version seems to be preferred among most devs.)

[stippi]

BTW, I know the code was like that before and you just cleaned it up, but the defensive programmers version would be more like this:

    BMenuItem* item = fFont->Menu()->FindItem(
        PrefHandler::Default()->getString(PREF_HALF_FONT_FAMILY));
    if (item != NULL)
        item->SetMarked(true);

On the other hand, that would probably just hide an error elsewhere (mismatch of strings)... ;-)

[bonefish]

Replying to stippi:

(Your version does have it's appeal because of clarity, but the other version seems to be preferred among most devs.)

Also very clear (even more so than the original version IMHO) and conforming to the style guide:

    fFont->Menu()->FindItem(PrefHandler::Default()->getString(
            PREF_HALF_FONT_FAMILY))
        ->SetMarked(true);

[jackburton]

I'll apply this.

[jackburton]

Applied (with the change proposed by Ingo) in hrev34734. Thanks!