Opened 10 years ago

Closed 10 years ago

#5256 closed bug (fixed)

Failure in build_haiku_image not propagated to jam.

Reported by: mmadia Owned by: bonefish
Priority: normal Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description (last modified by mmadia)

hrev35086's @alpha-raw fails to build due to size constraints. This error is not recognized by jam.

Unzipping /generated/x86gcc2/download/bebook_20081026.zip ...
Unzipping /generated/x86gcc2/download/BePDF-1.1.1b2-r1a1-x86-gcc2-2009-09-03.zip ...
Unzipping /generated/x86gcc2/download/Vision-0.9.7-H-090423.zip ...
Unzipping /generated/x86gcc2/download/VLC-0.8.6d.zip ...
Error while writing to file `/myfs/apps/vlc-0.8.6d/plugins/libfaad_plugin.so': No space left on device
Error: Command failed: No space left on device
Error: Command was:
  cp -f -r :/generated/x86gcc2/tmp/unzip/. /myfs/apps
Unzipping /generated/x86gcc2/download/WonderBrush-2.1.2.zip ...
Error while writing to file `/myfs/apps/WonderBrush/Documentation de/images/even_odd.png': No space left on device
Error: Command failed: No space left on device
Error: Command was:
  cp -f -r :/generated/x86gcc2/tmp/unzip/. /myfs/apps
Deleting old MIME database ...
Error: Failed to make directory "/myfs/home/config/settings/beos_mime": General system error
Error: Command failed: General system error
Error: Command was:
  mkdir -p /myfs/home/config/settings/beos_mime
Installing MIME database ...
Error: Failed to create `/myfs/home/config/settings/beos_mime': General system error
Error: Command failed: General system error
Error: Command was:
  cp -f -r :/generated/x86gcc2/tmp/mime/db/. /myfs/home/config/settings/beos_mime
Error while writing to attribute `COPYRIGHTS' of file `/myfs/system/apps/AboutSystem': No space left on device
Error: Command failed: No space left on device
Error: Command was:
  cp -a :/generated/x86gcc2/tmp/copyrightAttrs /myfs/system/apps/AboutSystem
Unmounting ...
...updated 539 target(s)...
/generated/x86gcc2> echo $?
0
/generated/x86gcc2> 

Attachments (3)

build_haiku_imageExitOnUnzipFailure.patch (444 bytes ) - added by mmadia 10 years ago.
build_haiku_imageExitOnUnzipFailureParanoid.patch (3.4 KB ) - added by mmadia 10 years ago.
build_haiku_image-sansPipeExit1-useSet_e.patch (975 bytes ) - added by mmadia 10 years ago.
use "set -o errexit" instead of "... || exit 1"

Download all attachments as: .zip

Change History (7)

comment:1 by mmadia, 10 years ago

Description: modified (diff)

comment:2 by mmadia, 10 years ago

The first patch build_haiku_imageExitOnUnzipFailure.patch , adds "
exit 1" to just the command for copying the unzipped optional package into the image file. The latter, build_haiku_imageExitOnUnzipFailureParanoid.patch spams " exit 1" to the majority of commands.

jam -q @alpha-raw :

Unzipping /generated/x86gcc2/download/Vision-0.9.7-H-090423.zip ...
Unzipping /generated/x86gcc2/download/VLC-0.8.6d.zip ...
Error while writing to file `/myfs/apps/vlc-0.8.6d/plugins/libfaad_plugin.so': No space left on device
Error: Command failed: No space left on device
Error: Command was:
  cp -f -r :/generated/x86gcc2/tmp/unzip/. /myfs/apps

export imagePath="/generated/x86gcc2/haiku-alpha.image"
export isImage="1"
export isVMwareImage=""
/haiku-src/haiku/build/scripts/build_haiku_image /generated/x86gcc2/haiku.image-init-vars /generated/x86gcc2/haiku.image-make-dirs /generated/x86gcc2/haiku.image-copy-files /generated/x86gcc2/haiku.image-unzip-files

...failed BuildHaikuImage1 /generated/x86gcc2/haiku-alpha.image ...
...removing /generated/x86gcc2/haiku-alpha.image
...failed updating 1 target(s)...
...updated 538 target(s)...
/generated/x86gcc2> echo $?
1
/generated/x86gcc2> 

comment:3 by bonefish, 10 years ago

I'd much rather see a solution using "set -e". That would also allow the exiting instances of "
exit 1" to be removed.

by mmadia, 10 years ago

use "set -o errexit" instead of "...
exit 1"

comment:4 by mmadia, 10 years ago

Resolution: fixed
Status: newclosed

Committed in hrev35151. Thanks!

Note: See TracTickets for help on using tickets.