Opened 10 years ago

Closed 5 years ago

#5285 closed bug (fixed)

Aesthetic bug in Mail app

Reported by: xeon3d Owned by: bga
Priority: normal Milestone: R1
Component: Applications/Mail Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #5732
Has a Patch: yes Platform: All

Description (last modified by diver)

When changing the language to Portuguese, the Mail window isn't resized properly. Please check the attached screenshots, since it's kinda late here to properly describe it.

Screenshot of the affected area

Attachments (2)

Haiku-2010-01-18-02-37-48.png (44.3 KB ) - added by xeon3d 10 years ago.
Screenshot of the affected area
0001-Fix-5285-Aesthetic-bug-in-Mail-app.patch (8.1 KB ) - added by gbonvehi 6 years ago.
Calculate base width using widest string

Download all attachments as: .zip

Change History (11)

by xeon3d, 10 years ago

Screenshot of the affected area

comment:1 by xeon3d, 10 years ago

Forgot to add that it might affect other languages as well.

by gbonvehi, 6 years ago

Calculate base width using widest string

comment:2 by gbonvehi, 6 years ago

Has a Patch: set

comment:3 by gbonvehi, 6 years ago

Let me know how I can improve this patch. For example, should I use k prefix for a BString? Originally I did it using const char* but I tried to follow the guidelines to use B classes whenever possible/convinient.

The best solution would be to rewrite the layout of the program using BLayouts but that's going to be a bigger task, this patch takes care of the bug :)

Thanks, Guillermo

Last edited 6 years ago by gbonvehi (previous) (diff)

comment:4 by diver, 5 years ago

Blocking: 5732 added

comment:5 by diver, 5 years ago

Blocking: 5732 removed
Description: modified (diff)
Keywords: visual language resize removed
Platform: x86All
Priority: lownormal
Summary: Aesthetic bug in Mail app.Aesthetic bug in Mail app

comment:6 by pulkomandy, 5 years ago

Patch looks good, but indeed converting to BLayout would be a better solution.

comment:7 by gbonvehi, 5 years ago

I'm glad it looks good, maybe it can be applied while someone rewrites it using layout, that would prevent more issues about this and also make the e-mail client usable while it's done.

Cheers, Guillermo

comment:8 by pulkomandy, 5 years ago

Blocking: 5732 added

comment:9 by pulkomandy, 5 years ago

Resolution: fixed
Status: newclosed

Applied in hrev48700.

Note: See TracTickets for help on using tickets.