Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5445 closed bug (fixed)

[patch] (ReadOnlyBootPrompt) Keymap list doesn't scroll to selection

Reported by: idefix Owned by: nobody
Priority: normal Milestone: R1
Component: Applications Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All


When ReadOnlyBootPrompt is started, the selection in the Keymap list isn't visible because the list isn't scrolled to it. The list should scroll to the selection, but it doesn't do that. I think because the list isn't added to a view at that point.

That could be a bug in the interface kit (as this TODO points out), but I attached a patch that will (temporarily) fix this issue in ReadOnlyBootPrompt.

Attachments (1)

readonlybootprompt.patch (570 bytes) - added by idefix 9 years ago.
(patch) Scroll to selection after list is added to a view.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by idefix

Attachment: readonlybootprompt.patch added

(patch) Scroll to selection after list is added to a view.

comment:1 Changed 9 years ago by stippi

Resolution: fixed
Status: newclosed

The patch as is is wrong, since it removes the scrolling when the keymap is adjusted later on (the lists are rebuilt when you update the lanuage). But I've added a comment and applied the rest of the patch in hrev35570. Thanks!

comment:2 Changed 9 years ago by idefix

Ah yes, I didn't think of the rebuilding. Thanks for the quick response!

On a related note:
When there will be a lot of languages above English, the Language list also needs a ScrollToSelection() there. I didn't add it in this patch, because the list would look a little bit weird in this case (too few languages above English)...

Note: See TracTickets for help on using tickets.