MediaPlayer repeats audio and video after second play

[jstressman]

Auronandace pointed this out and asked me to double check it, test if it affected videos, and report the bug.

To recreate the bug, play an mp3 all the way through, then click the play button again and let it play through again. After this second play through the song will start playing a third time by itself with the seek widget still sitting at the end of the time bar. After this repeat it will stop like it's supposed to.

Clicking play again will repeat the double play on subsequent plays. Only the first play stops correctly at the end.

Almost the same behavior can be seen on videos, except that the seek widget also moves along the progress bar on the repeat plays, unlike for the audio tracks. It will also play twice by itself on every play after the first play.

(It just did it again for a song, but this time the seek widget also reset and is moving along correctly...)

I'm attaching a picture of it playing the second repeat but with the widget still sitting at the end of the progress bar.

(I tested this in hrev35808 gcc4hybrid)

[jstressman]

song repeating a third time after clicking play a second time and letting song run to the end. seek widget still sitting at end of progress bar from previous play.

[axeld]

(In #2965) Bug #5568 also mentions that video is affected.

[axeld]

Fixed in hrev36392.