Opened 15 years ago
Closed 15 years ago
#5573 closed enhancement (fixed)
[Patch] Deskbar localization
Reported by: | mt | Owned by: | pulkomandy |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Kits/Locale Kit | Version: | R1/Development |
Keywords: | Deskbar | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
Localize GUI strings for Deskbar. Patch and en.catkeys added.
ISSUE:
- "Mount" menu does not appear in en.catkeys. (perhaps preprocessor skip #ifdef MOUNT_MENU_IN_DESKBAR.) It seems DoCatalogs does not use SubDirC++Flags.
TODO:
- Localize CalendarMenuWindow and BCalendarView.
- Modify TTimeView and related prefernce to display localized time.
- Localize Applications, Demos, Desktop applets, Preferences folder name in BeMenu. (I think this is Installer's work.)
Attachments (3)
Change History (6)
by , 15 years ago
Attachment: | Deskbar.patch added |
---|
comment:1 by , 15 years ago
Status: | new → in-progress |
---|
You are doing this (also with some other #ifdef blocks, this one is an example) :
235 242 #ifdef HAIKU_DISTRO_COMPATIBILITY_OFFICIAL 236 "About Haiku" 243 TR("About Haiku" B_UTF8_ELLIPSIS) 237 244 #else 238 "About this system" 245 TR("About this system" B_UTF8_ELLIPSIS) 239 246 #endif
Basically this will not work as expected : one of the strings will not be in the .catkeys file. I see two solutions :
- Have both strings in the catkey file and let one never be used on a given Haiku install. This can be done by TR_MARKing the strings outside of the #if block
- Have only one string translated, and swap the catalogs at runtime. This is cleaner in terms of distribution, but complexifies the handling of catkeys files (not en.catkeys, but all the others)
I'll ask the other devs what they think about it and look at the TODOs. Not applying the patch until a proper solution is found for this problem.
comment:2 by , 15 years ago
I think solution #1 (TR_MARKing the strings outside of the #if block) is better, so I made another patch. please review.
by , 15 years ago
Attachment: | Deskbar.2.patch added |
---|
patch 2 (TR_MARKing the strings outside of the #if block)
patch file