Opened 10 years ago

Closed 9 years ago

#5573 closed enhancement (fixed)

[Patch] Deskbar localization

Reported by: mt Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Kits/Locale Kit Version: R1/Development
Keywords: Deskbar Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Localize GUI strings for Deskbar. Patch and en.catkeys added.

ISSUE:

  • "Mount" menu does not appear in en.catkeys. (perhaps preprocessor skip #ifdef MOUNT_MENU_IN_DESKBAR.) It seems DoCatalogs does not use SubDirC++Flags.

TODO:

  • Localize CalendarMenuWindow and BCalendarView.
  • Modify TTimeView and related prefernce to display localized time.
  • Localize Applications, Demos, Desktop applets, Preferences folder name in BeMenu. (I think this is Installer's work.)

Attachments (3)

Deskbar.patch (17.2 KB ) - added by mt 10 years ago.
patch file
en.catkeys (1.7 KB ) - added by mt 10 years ago.
catkey file
Deskbar.2.patch (17.6 KB ) - added by mt 9 years ago.
patch 2 (TR_MARKing the strings outside of the #if block)

Download all attachments as: .zip

Change History (6)

by mt, 10 years ago

Attachment: Deskbar.patch added

patch file

by mt, 10 years ago

Attachment: en.catkeys added

catkey file

comment:1 by pulkomandy, 10 years ago

Status: newin-progress

You are doing this (also with some other #ifdef blocks, this one is an example) :

235	242	#ifdef HAIKU_DISTRO_COMPATIBILITY_OFFICIAL 
236	 	    "About Haiku" 
 	243	    TR("About Haiku" B_UTF8_ELLIPSIS) 
237	244	#else 
238	 	    "About this system" 
 	245	    TR("About this system" B_UTF8_ELLIPSIS) 
239	246	#endif 

Basically this will not work as expected : one of the strings will not be in the .catkeys file. I see two solutions :

  • Have both strings in the catkey file and let one never be used on a given Haiku install. This can be done by TR_MARKing the strings outside of the #if block
  • Have only one string translated, and swap the catalogs at runtime. This is cleaner in terms of distribution, but complexifies the handling of catkeys files (not en.catkeys, but all the others)

I'll ask the other devs what they think about it and look at the TODOs. Not applying the patch until a proper solution is found for this problem.

comment:2 by mt, 9 years ago

I think solution #1 (TR_MARKing the strings outside of the #if block) is better, so I made another patch. please review.

by mt, 9 years ago

Attachment: Deskbar.2.patch added

patch 2 (TR_MARKing the strings outside of the #if block)

comment:3 by pulkomandy, 9 years ago

Resolution: fixed
Status: in-progressclosed

Applied in hrev36117.

Note: See TracTickets for help on using tickets.