Opened 10 years ago

Closed 5 years ago

Last modified 5 years ago

#5588 closed bug (fixed)

[Sounds] zoom button should resize to fit (easy)

Reported by: diver Owned by: waddlesplash
Priority: normal Milestone: R1/beta1
Component: Preferences/Sounds Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #6507, #8665, #8676
Has a Patch: yes Platform: All

Description

Zoom button in Sounds preflet should resize to fit instead of maximizing it's window.

Attachments (3)

SoundsZoom.diff (1.3 KB ) - added by devine 7 years ago.
This makes the Sounds zoom behave the same as Tracker's zoom.
0001-Patched-to-address-5588.-Fix-resizing.patch (1.6 KB ) - added by devine 7 years ago.
Patch in the proper format.
0001-Patched-to-address-5588.-Fix-resizing.2.patch (1.6 KB ) - added by devine 7 years ago.
Patch in the proper format.

Download all attachments as: .zip

Change History (17)

comment:1 by Disreali, 8 years ago

I assume you mean similar to how Tracker behaves? That might be nice, however, you then get into changing a consistent zoom behaviour for some apps. ShowImage and Web+ already have been made problematic by changes to their zoom behaviour. I don't know if it is worth making the behaviour inconsistent is really worth while.

comment:2 by humdinger, 8 years ago

I'm with diver here. The zoom button is not a Windows-like maximise button, but an alternative-size-button. It should always change the window size to what's appropriate. In general it should resize to an optimal size IMO, i.e. work like Tracker windows. It makes no sense to have the Sounds prefs window maximized to "fullscreen".
I also agree that ShowImage's and MediaPlayer's zoom buttons currently don't behave nicely in that regard.

comment:3 by diver, 8 years ago

Blocking: 6507 added

comment:4 by diver, 7 years ago

Summary: [Sounds] zoom button should resize to fit[Sounds] zoom button should resize to fit (easy)

by devine, 7 years ago

Attachment: SoundsZoom.diff added

This makes the Sounds zoom behave the same as Tracker's zoom.

comment:5 by devine, 7 years ago

Has a Patch: set

comment:6 by diver, 7 years ago

Blocking: 8676 added

(In #8676) Indeed.

comment:7 by mmadia, 7 years ago

Blocking: 8665 added

comment:8 by mmadia, 7 years ago

Hi, thanks for working on this!

(from IRC) Could anyone comment if the name of the label and the text in the message will always be the same? for example in French I think it would be "Adresse IP:" and "L'adresse IP est invalide".

Maybe simply separate the error message from the label, just in case.

Lastly, please re-create and re-attach it with git format-patch so you'll be credited correctly. Please cf. SubmittingPatches. This will provide you with better recognition for the contribution.

Last edited 7 years ago by mmadia (previous) (diff)

comment:9 by mmadia, 7 years ago

B_NEED_MORE_COFFEE. Aside from the git format-patch, ignore the above comment. That text was meant for #9089.

by devine, 7 years ago

Patch in the proper format.

by devine, 7 years ago

Patch in the proper format.

comment:10 by devine, 7 years ago

Greetings,

Matt tested the patch and said that the vertical scroll-bar should be disabled when the window is Zoomed because it should re-size to a size where scrolling is not needed.

I don't agree personally. I think the size that it goes to is nice, and if that list gets longer then Matts suggestion will be ugly.

Korli?

(Also, sorry about uploading that patch twice... Trac re-uploads the file if you use the back-button after uploading.)

comment:11 by scottmc, 5 years ago

Can anyone test and if ok apply this one?

comment:12 by waddlesplash, 5 years ago

Milestone: R1R1/alpha5
Owner: changed from korli to waddlesplash
Status: newassigned

I'll get to it at some point before August.

comment:13 by pulkomandy, 5 years ago

Resolution: fixed
Status: assignedclosed

Fixed in hrev48143.

comment:14 by pulkomandy, 5 years ago

Milestone: R1/alpha5R1/beta1
Note: See TracTickets for help on using tickets.