Opened 7 years ago

Closed 7 years ago

#9089 closed enhancement (fixed)

Add Localization to Network preference

Reported by: mt Owned by: axeld
Priority: normal Milestone: R1
Component: Preferences/Network Version: R1/Development
Keywords: Localization Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Hi, This patch adds a localization to Network preference (localize warning for invalid input).

Attachments (2)

network.diff (876 bytes ) - added by mt 7 years ago.
0001-networl-patch-2.patch (1.5 KB ) - added by mt 7 years ago.

Download all attachments as: .zip

Change History (6)

by mt, 7 years ago

Attachment: network.diff added

comment:1 by mt, 7 years ago

Has a Patch: set

comment:2 by mmadia, 7 years ago

Hi, thanks for working on this!

(from IRC) Could anyone comment if the name of the label and the text in the message will always be the same? for example in French I think it would be "Adresse IP:" and "L'adresse IP est invalide".

Maybe simply separate the error message from the label, just in case.

Lastly, please re-create and re-attach it with git format-patch so you'll be credited correctly. Please cf. SubmittingPatches. This will provide you with better recognition for the contribution.

comment:3 by mt, 7 years ago

Hi, I renewed patch. please recheck.

by mt, 7 years ago

Attachment: 0001-networl-patch-2.patch added

comment:4 by mmadia, 7 years ago

Resolution: fixed
Status: newclosed

Thanks again! Applied in hrev45293.

Note: See TracTickets for help on using tickets.