#5588 closed bug (fixed)
[Sounds] zoom button should resize to fit (easy)
| Reported by: | diver | Owned by: | waddlesplash |
|---|---|---|---|
| Priority: | normal | Milestone: | R1/beta1 |
| Component: | Preferences/Sounds | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | #6507, #8665, #8676 | |
| Platform: | All |
Description
Zoom button in Sounds preflet should resize to fit instead of maximizing it's window.
Attachments (3)
Change History (17)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
I'm with diver here. The zoom button is not a Windows-like maximise button, but an alternative-size-button. It should always change the window size to what's appropriate. In general it should resize to an optimal size IMO, i.e. work like Tracker windows. It makes no sense to have the Sounds prefs window maximized to "fullscreen".
I also agree that ShowImage's and MediaPlayer's zoom buttons currently don't behave nicely in that regard.
comment:3 by , 13 years ago
| Blocking: | 6507 added |
|---|
comment:4 by , 13 years ago
| Summary: | [Sounds] zoom button should resize to fit → [Sounds] zoom button should resize to fit (easy) |
|---|
by , 13 years ago
| Attachment: | SoundsZoom.diff added |
|---|
This makes the Sounds zoom behave the same as Tracker's zoom.
comment:5 by , 13 years ago
| patch: | 0 → 1 |
|---|
comment:7 by , 12 years ago
| Blocking: | 8665 added |
|---|
comment:8 by , 12 years ago
Hi, thanks for working on this!
Please re-create and re-attach it with git format-patch so you'll be credited correctly. Please cf. SubmittingPatches. This will provide you with better recognition for the contribution.
comment:9 by , 12 years ago
B_NEED_MORE_COFFEE. Aside from the git format-patch, ignore the above comment. That text was meant for #9089.
by , 12 years ago
| Attachment: | 0001-Patched-to-address-5588.-Fix-resizing.patch added |
|---|
Patch in the proper format.
by , 12 years ago
| Attachment: | 0001-Patched-to-address-5588.-Fix-resizing.2.patch added |
|---|
Patch in the proper format.
comment:10 by , 12 years ago
Greetings,
Matt tested the patch and said that the vertical scroll-bar should be disabled when the window is Zoomed because it should re-size to a size where scrolling is not needed.
I don't agree personally. I think the size that it goes to is nice, and if that list gets longer then Matts suggestion will be ugly.
Korli?
(Also, sorry about uploading that patch twice... Trac re-uploads the file if you use the back-button after uploading.)
comment:12 by , 10 years ago
| Milestone: | R1 → R1/alpha5 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
I'll get to it at some point before August.
comment:14 by , 10 years ago
| Milestone: | R1/alpha5 → R1/beta1 |
|---|
I assume you mean similar to how Tracker behaves? That might be nice, however, you then get into changing a consistent zoom behaviour for some apps. ShowImage and Web+ already have been made problematic by changes to their zoom behaviour. I don't know if it is worth making the behaviour inconsistent is really worth while.