Opened 9 years ago

Closed 9 years ago

#5706 closed enhancement (fixed)

Changed Inode ID bounds check

Reported by: jvff Owned by: axeld
Priority: normal Milestone: R1
Component: File Systems/ext2 Version: R1/alpha1
Keywords: gsoc2010 ext2 inode NumInodes Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

In "kernel_interface.cpp", I changed the Inode ID bounds so it would limit the Inode ID to the maximum number of Inodes in the file system. It also contains a superblock check to see if it indicates that the file system has errors.

Attachments (2)

ext2_numInodes.patch (2.0 KB) - added by jvff 9 years ago.
ext2_numInodes2.patch (1.8 KB) - added by jvff 9 years ago.
Patch containing only changes relative to inode bounds checking.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by jvff

Attachment: ext2_numInodes.patch added

comment:1 Changed 9 years ago by mmadia

Keywords: gsoc2010 added

comment:2 Changed 9 years ago by axeld

I like it, but I have one coding style remark, and one suggestion:

  • Multiline statements after an if/for/while should be enclosed in curly braces.
  • Instead of using something like State() == 2, define constants for the known states, and check against those.

Thanks!

Changed 9 years ago by jvff

Attachment: ext2_numInodes2.patch added

Patch containing only changes relative to inode bounds checking.

comment:3 Changed 9 years ago by korli

Resolution: fixed
Status: newclosed

Applied in hrev36358.

Note: See TracTickets for help on using tickets.