Opened 9 years ago

Closed 5 years ago

#5721 closed bug (fixed)

LinkInstallZip breaks when jamming outside of HAIKU_TOP

Reported by: mmadia Owned by: bonefish
Priority: low Milestone: R1
Component: Build System Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Currently PackageRules#L247's LinkInstallZip assumes `pwd` = $(HAIKU_TOP) = '.'

An example reproduction

cd <generated>
jam -qdadx haiku-ipw2100-cvs

The following improves the situation, but isn't a clean solution nor does it work when <generated> is a symlink.

Index: build/jam/PackageRules
===
 actions together LinkInstallZip
 {
-	ln -sf "`pwd`/$(2)" "$(1)" ;
+	if [ "$HAIKU_TOP" == '.' ]; then
+		ln -sf "`pwd`/$(2)" "$(1)" ; 
+	else
+		ln -sf "$(2)" "$(1)" ;
+	fi
+	
 }

Change History (2)

comment:1 Changed 9 years ago by bonefish

Priority: normallow

IMO the package rules should be removed completely and the Jamfiles be cleaned up. Their main purpose was to be able to build component installation packages for BeOS back when Haiku was far away from being usable.

comment:2 Changed 5 years ago by bonefish

Resolution: fixed
Status: newclosed

The rules have been removed.

Note: See TracTickets for help on using tickets.