Opened 9 years ago

Closed 9 years ago

#5733 closed bug (fixed)

[patch] screenshot uses wrong translator id values

Reported by: augiedoggie Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/Screenshot Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The screenshot app uses hardcoded translator_id values. As a result of translator changes at some point in the past it would no longer find the proper type info from the translation roster. This caused it to not append the appropriate extensions on file names. I'm attaching a patch which corrects the values.

Attachments (3)

screenshot.diff (1.4 KB ) - added by augiedoggie 9 years ago.
screenshot2.diff (6.7 KB ) - added by augiedoggie 9 years ago.
alternate patch which removes the hardcoded id values
screenshot3.diff (6.7 KB ) - added by augiedoggie 9 years ago.
revised alternate patch which looks up translator id values on demand

Download all attachments as: .zip

Change History (9)

by augiedoggie, 9 years ago

Attachment: screenshot.diff added

by augiedoggie, 9 years ago

Attachment: screenshot2.diff added

alternate patch which removes the hardcoded id values

comment:1 by stippi, 9 years ago

The second patch is the good one. I am wondering though, if passing the translator ID is needed at all. If memory doesn't fail me, it should be enough to pass the image format constant.

comment:2 by augiedoggie, 9 years ago

I thought about that as well but MessageReceived() wants to receive a "be:translator" so i didn't look into whether it would break something else to remove that.

by augiedoggie, 9 years ago

Attachment: screenshot3.diff added

revised alternate patch which looks up translator id values on demand

comment:3 by augiedoggie, 9 years ago

I've modified the patch so that it doesn't track the translator_id and uses the _FindTranslator() method for all of the ID lookups. I haven't noticed any problems using this in the testing that I've done.

comment:4 by stippi, 9 years ago

Owner: changed from julun to stippi
Status: newin-progress

comment:5 by stippi, 9 years ago

Applied in hrev36342.

comment:6 by stippi, 9 years ago

Resolution: fixed
Status: in-progressclosed

Forgot to close.

Note: See TracTickets for help on using tickets.