#5908 closed enhancement (fixed)
CodyCam localization patch
| Reported by: | Karvjorm | Owned by: | mmu_man |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/CodyCam | Version: | R1/alpha1 |
| Keywords: | CodyCam localization patch | Cc: | Karvjorm |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
Here is a localization patch for CodyCam application.
Attachments (2)
Change History (11)
comment:1 by , 15 years ago
by , 15 years ago
| Attachment: | codycamLocalization.patch added |
|---|
A localization patch for CodyCam application
comment:3 by , 15 years ago
I am really not sure about translating all the debugging messages (LOOP(), INFO(), ERROR(), etc). I think it's better to revert this part of the patch. I am not even sure about translating regular terminal output, since it will make it harder for anyone to perform a Google query on an error message. But I can understand if those are translated. However, debugging messages that only a programmer should see are really too much. They just bloat the catalogs.
comment:4 by , 15 years ago
I can fix those debug messages but just tonight I have theater tickets and can concentrate this one first tomorrow.
by , 15 years ago
| Attachment: | codycamLocalization.2.patch added |
|---|
A fixed localization patch for CodyCam application.
comment:5 by , 15 years ago
Here is a fix for CodyCam localization patch (it is updated now). But there are some problems: I have used B_TRANSLATE macros, but my development environment is not up-to-date and here I have defined macros explicitly. They should be removed before commit (and testing, I hope).
Also, I actually do not known how to compile the working application (specially with my not-up-to-date environment) and I have simply tested .cpp files by this way:
g++ -c -I/Blank_BFS/haiku/src/apps/codycam/ CodyCam.cpp
Also, I have still implemented some stderr messages, specially those seen in the ftp-wiew, because I suppose, that users need information about failure with her/his own language.
br, Karvjorm
comment:6 by , 15 years ago
| patch: | → 0 |
|---|
comment:7 by , 15 years ago
| patch: | 0 → 1 |
|---|
comment:8 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Applied in hrev36850. You gotta watch out for static initializations of strings. Those would happen before loading the app catalog and thus crash. See my changes to CodyCam.h and CodyCam.cpp (perhaps not ideal, since they would need to be kept in sync).
comment:9 by , 15 years ago
There is a lot of debug output which is localized now, I think this part should be reverted.
Oops, I did not remember to localize GetReadText(), GetLReadText(), and GetReplyText() in header file. I will update this patch.