Opened 9 years ago

Closed 9 years ago

#6064 closed enhancement (fixed)

BaseTranslator localization patch in src/add-ons/translators/shared/

Reported by: Karvjorm Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Add-Ons/Translators Version: R1/alpha2
Keywords: BaseTranslator shared Translator Add-Ons localization Cc: Karvjorm
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Here is a localization patch for BaseTranslators & co in src/add-ons/translators/shared/

Attachments (1)

BaseTranslatorsLocalization.patch (7.8 KB) - added by Karvjorm 9 years ago.
An updated BaseTranslatorsLocalization patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by stippi

Has a Patch: set

comment:2 Changed 9 years ago by stippi

Thanks! Please mark the attachements as patches next time. The Jamfile is missing the DoCatalogs rule, do you want to fix that and re-attach the patches?

comment:3 in reply to:  2 Changed 9 years ago by Karvjorm

Replying to stippi:

Thanks! Please mark the attachements as patches next time. The Jamfile is missing the DoCatalogs rule, do you want to fix that and re-attach the patches?

Oops, I will do it next time. DoCatalogs rule? A new thing to learn. ;) I will try to do it also.

comment:4 Changed 9 years ago by Karvjorm

I updated localization patch for the BaseTranslator classs. I also noticed that derived classes are passing name and info strings to the BaseTranslator class via constructors and decided to localize them here. Some translators (like GIF translator) do not use BaseTranslator, but I have ignored it (now localization is ready, if GIF translator code changes later on).

comment:5 Changed 9 years ago by pulkomandy

Owner: changed from nobody to pulkomandy
Status: newassigned

comment:6 Changed 9 years ago by pulkomandy

Hello, It is not a good idea to translate other translator's names here, because this class is meant to be generic and not depend on things defined in subclasses. So each translator should take care of adjusting its own name.

Otherwise, the patch looks fine, so I'm waiting for an updated version !

comment:7 in reply to:  6 Changed 9 years ago by Karvjorm

Replying to pulkomandy:

Hello, It is not a good idea to translate other translator's names here, because this class is meant to be generic and not depend on things defined in subclasses. So each translator should take care of adjusting its own name.

Otherwise, the patch looks fine, so I'm waiting for an updated version !

OK, i hope I have time to do this soon.

Changed 9 years ago by Karvjorm

An updated BaseTranslatorsLocalization patch

comment:8 Changed 9 years ago by pulkomandy

Resolution: fixed
Status: assignedclosed

Applied in hrev37462.

Note: See TracTickets for help on using tickets.