BaseTranslator localization patch in src/add-ons/translators/shared/

[Karvjorm]

Here is a localization patch for BaseTranslators & co in src/add-ons/translators/shared/

[stippi]

Thanks! Please mark the attachements as patches next time. The Jamfile is missing the DoCatalogs rule, do you want to fix that and re-attach the patches?

[Karvjorm]

Replying to stippi:

Thanks! Please mark the attachements as patches next time. The Jamfile is missing the DoCatalogs rule, do you want to fix that and re-attach the patches?

Oops, I will do it next time. DoCatalogs rule? A new thing to learn. ;) I will try to do it also.

[Karvjorm]

I updated localization patch for the BaseTranslator classs. I also noticed that derived classes are passing name and info strings to the BaseTranslator class via constructors and decided to localize them here. Some translators (like GIF translator) do not use BaseTranslator, but I have ignored it (now localization is ready, if GIF translator code changes later on).

[pulkomandy]

Hello, It is not a good idea to translate other translator's names here, because this class is meant to be generic and not depend on things defined in subclasses. So each translator should take care of adjusting its own name.

Otherwise, the patch looks fine, so I'm waiting for an updated version !

[Karvjorm]

Replying to pulkomandy:

Hello, It is not a good idea to translate other translator's names here, because this class is meant to be generic and not depend on things defined in subclasses. So each translator should take care of adjusting its own name.

Otherwise, the patch looks fine, so I'm waiting for an updated version !

OK, i hope I have time to do this soon.

[Karvjorm]

An updated BaseTranslatorsLocalization patch

[pulkomandy]

Applied in hrev37462.