Opened 14 years ago

Closed 14 years ago

#6075 closed enhancement (fixed)

Inspector localization patch

Reported by: Karvjorm Owned by: pulkomandy
Priority: normal Milestone: R1
Component: - General Version: R1/alpha2
Keywords: Inspector localization patch Cc: Karvjorm
Blocked By: Blocking:
Platform: All

Description

Here is a localization patch for Inspector found in src/tools/translation/inspector directory.

Attachments (1)

InspectorLocalization.patch​ (19.4 KB ) - added by Karvjorm 14 years ago.
An updated patch for Inspector localization.

Download all attachments as: .zip

Change History (5)

comment:1 by Karvjorm, 14 years ago

patch: 0 → 1

comment:3 by pulkomandy, 14 years ago

Owner: changed from nobody to pulkomandy
Status: new → assigned

comment:4 by pulkomandy, 14 years ago

Some little things to change here...

  • main() is not the right place to get the catalog, it should be done in the InspectorApp constructor,and BCatalog should be a member of the class InspectorApp. If you do it otherwise, the BCatalog will be destructed as soon as main finishes executing, which may happen before the window is closed. If you then call B_TRANSLATE, it will crash (this will happen when opening a menu, an alert, or in many other cases)
  • Beware of sprintf. You are trying to use sprintf(NULL,format,int), this will not work. You have to provide sprintf with a big enough buffer. (ImageView.cpp:451). I think it would be simpler to use a BString for str2 instead. The same apply for (apparently) all the places where you use sprintf.

by Karvjorm, 14 years ago

Attachment: InspectorLocalization.patch​ added

An updated patch for Inspector localization.

comment:5 by pulkomandy, 14 years ago

Resolution: → fixed
Status: assigned → closed

Applied in hrev37208. Thanks!

Note: See TracTickets for help on using tickets.