Opened 10 years ago

Closed 9 years ago

#6092 closed enhancement (fixed)

Localization for NetworkStatus application

Reported by: Karvjorm Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Applications Version: R1/alpha2
Keywords: NetworkStatus localization patch libbe.so build fail Cc: Karvjorm
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Here is a localization patch for NetworkStatus application. For some reason I was not able to build it because of failed buildning of libbe.so (dependecies with icon files?).

Attachments (2)

libicon_a_error.png (65.1 KB ) - added by Karvjorm 10 years ago.
Error message when trying to build NetworkStatus application
NetworkStatusLocalization.patch (7.7 KB ) - added by Karvjorm 9 years ago.
An updated localization patch for NetworkStatus

Download all attachments as: .zip

Change History (7)

comment:1 by Karvjorm, 10 years ago

Has a Patch: set

by Karvjorm, 10 years ago

Attachment: libicon_a_error.png added

Error message when trying to build NetworkStatus application

comment:2 by Karvjorm, 10 years ago

Summary: Localization for NetworStatus applicationLocalization for NetworkStatus application

I fixed also Summary line typo. And there were 2 bugs, (= instead of +=) that I already fixed. It's better to sleep some hours because of many errors. ;)

comment:3 by pulkomandy, 9 years ago

Owner: changed from nobody to pulkomandy
Status: newassigned

comment:4 by pulkomandy, 9 years ago

The part with strncmp() in NetworkStatusView:359 feels a bit hacky to me. Also, kstatusDescriptions is a const, so you can't change it this way. Instead, you have to use TR_MARK (or whatever the macro to "mark for translation" was renamed to), on the static strings in line 51. Then, you have to call B_TRANSLATE in all the places where the table is actually used, for example printf(kStatusDescriptions[2]) becomes printf(B_TRANSLATE(kStatusDescrptions[2])).

by Karvjorm, 9 years ago

An updated localization patch for NetworkStatus

comment:5 by pulkomandy, 9 years ago

Resolution: fixed
Status: assignedclosed

Applied in hrev37337. Thanks !

Note: See TracTickets for help on using tickets.