[media_addon_server] crashes in BBuffer::SetHeader ()

[samui]

Try this

open more videos than your processor can handle. the playback will become jerky and choppy.

then try to adjust system volume from the deskbar widget. it does not respond to clicking. after few clicks deskbar crashes sporadically.

tested under virtualbox, 256mb of mem (that there was plenty free even with all the video going on).

[axeld]

Can you provide a stack trace from the crash?

See ReportingBugs under "Application Bugs" for more details, thanks!

Does it only happen when you play videos, or also if you are running apps like GLTeapot that also produce heavy load.

[samui]

attached image.

When processor is pegged to the max, deskbar becomes garbled and is unresponsive. this time i tested, media player died first, let me do the kdl thing and then died again giving the same popup. had about 14 h.264 vids running at the same time.

after the media player items were flushed, the deskbar redrew itself but was unresponsive and got garbled with processcontroller and volume controller drawing on top of each other. even five mins after the crash the deskbar shows 100% processor usage and is behaving slowly and erratically. virtualbox hovewer says haiku is not taxing the processor almost at all so its just processcontroller not redrawing the current state.

[samui]

tested on the latest nightly too, same thing happens. intel i5 processor, virtual memory disabled in haiku.

[stippi]

Can you please check if your test case runs without problems now?

[diver]

On attached screenshot it is media_addon_server which crashed MediaPlayer. Can you reproduce deskbar crash on recent revision?

[diver]

(In #9516) Thanks for the note.

[diver]

Still here in hrev48956. Easily reproducible when playing movies over sshfs (from haikuporter).

[Barrett]

All those BBuffer issues around, might be related to #4954? When enabling debugging, i realized that his happens when there's a fail in registering a BBuffer to the media_server, this seems a good clue to begin investigating on the source of the problems.

[Barrett]

Unregistering the buffer when it fails fixes the bug in my system.

[korli]

0001:

• BBuffer::ID() should return a negative value on bad registration (0 isn't a good one).

0003:

• "return OK;" could be factorized.

Thanks for your efforts! It's appreciated.

[korli]

Sorry but memset() writes bytes, you need to set fMediaHeader.buffer to a negative value, possibly fArea.

[Barrett]

I think i should avoid to do things at 00:00, sorry. I've not figured out that memset was unneeded.

[Barrett]

I think BBuffer::ID should be set to -1 until it's correctly registered to the media server, this also apply for other members. I've also set ID to fArea when cloning fails, as it seems you meant that. EDIT

Ok, i think i misunderstood the message, the patch should be OK now.

[stippi]

All three patches look good to me. Thanks for your efforts!

[pulkomandy]

Patches applied in hrev49035.