Opened 9 years ago

Last modified 7 years ago

#6201 assigned bug

History slows down menu opening

Reported by: X512 Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #8814
Has a Patch: no Platform: All

Description

When history is big menu open after 1-3 seconds.

Change History (10)

comment:1 Changed 9 years ago by stippi

This is indeed not working optimally, since the history menu is rebuilt everytime any menu is opened. What timeout have you configured for history items? The default is seven days and I didn't notice any problems with that. Or perhaps you are surfing a great many sites each day? Or your computer is rather slow. In any case, the problem should be addressed...

comment:2 in reply to:  1 Changed 9 years ago by X512

Replying to stippi:

This is indeed not working optimally, since the history menu is rebuilt everytime any menu is opened.

Mayble to cache history menu or build each day, not all menu like in Tracker.

What timeout have you configured for history items? The default is seven days and I didn't notice any problems with that.

7 days.

Or perhaps you are surfing a great many sites each day?

Yes.

comment:3 Changed 8 years ago by leavengood

Owner: changed from stippi to leavengood
Status: newassigned

Taking ownership.

comment:4 Changed 7 years ago by diver

Is it with any menu or only with History?

comment:5 Changed 7 years ago by stippi

See comment:1, the history is rebuilt every time any menu is opened in the main window. (Via the MenusBeginning() hook method, or similar.)

comment:6 Changed 7 years ago by anevilyak

Blocking: 8814 added

(In #8814) Replying to X512:

Duplicate of #6201.

Indeed, thanks.

comment:7 Changed 7 years ago by diver

Version: R1/alpha2R1/Development

comment:8 Changed 7 years ago by leavengood

Stephan, do you have any rough idea of how you would improve this?

I do know that we do need to flesh out the history API in our WebKit, though that is probably only marginally related to this.

I suppose an object could be created to manage this menu and either lazily rebuild it or modify it as the history is changed?

comment:9 Changed 7 years ago by axeld

Can't we utilize Tracker's various solutions to this, like BSlowMenu?

comment:10 in reply to:  8 Changed 7 years ago by stippi

Replying to leavengood:

Stephan, do you have any rough idea of how you would improve this?

I do know that we do need to flesh out the history API in our WebKit, though that is probably only marginally related to this.

I suppose an object could be created to manage this menu and either lazily rebuild it or modify it as the history is changed?

Yes, this is really just a matter of caching the information and knowing when to update it. At the time, I was interested in other stuff and wanted to get this going quickly. So it's just a case of programmer laziness. To fix this would not be complicated from what I recall.

Last edited 7 years ago by stippi (previous) (diff)
Note: See TracTickets for help on using tickets.