History slows down menu opening

[X512]

When history is big menu open after 1-3 seconds.

[stippi]

This is indeed not working optimally, since the history menu is rebuilt everytime any menu is opened. What timeout have you configured for history items? The default is seven days and I didn't notice any problems with that. Or perhaps you are surfing a great many sites each day? Or your computer is rather slow. In any case, the problem should be addressed...

[X512]

Replying to stippi:

This is indeed not working optimally, since the history menu is rebuilt everytime any menu is opened.

Mayble to cache history menu or build each day, not all menu like in Tracker.

What timeout have you configured for history items? The default is seven days and I didn't notice any problems with that.

7 days.

Or perhaps you are surfing a great many sites each day?

Yes.

[leavengood]

Taking ownership.

[diver]

Is it with any menu or only with History?

[stippi]

See comment:1, the history is rebuilt every time any menu is opened in the main window. (Via the MenusBeginning() hook method, or similar.)

[anevilyak]

(In #8814) Replying to X512:

Duplicate of #6201.

Indeed, thanks.

[leavengood]

Stephan, do you have any rough idea of how you would improve this?

I do know that we do need to flesh out the history API in our WebKit, though that is probably only marginally related to this.

I suppose an object could be created to manage this menu and either lazily rebuild it or modify it as the history is changed?

[axeld]

Can't we utilize Tracker's various solutions to this, like BSlowMenu?

[stippi]

Replying to leavengood:

Stephan, do you have any rough idea of how you would improve this?

I do know that we do need to flesh out the history API in our WebKit, though that is probably only marginally related to this.

I suppose an object could be created to manage this menu and either lazily rebuild it or modify it as the history is changed?

Yes, this is really just a matter of caching the information and knowing when to update it. At the time, I was interested in other stuff and wanted to get this going quickly. So it's just a case of programmer laziness. To fix this would not be complicated from what I recall.