Opened 9 years ago

Closed 9 years ago

#6402 closed enhancement (invalid)

BAlert titles needlessly translatable (Patch)

Reported by: humdinger Owned by: humdinger
Priority: normal Milestone: R1
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

While BAlert titles are visible as thread name (w>title), this is only of interest when debugging. And for debugging issues, they shouldn't be translated so we don't get "localized bugreports". So, attached patches for apps and prefs that used to have translated BAlert titles. (Originally I stumbled over these when doing some HTA translations, so this will also save some seconds of work for every language there... :)
If nobody thinks I'm doing wrong, I'll commit these patches in a few days.

Attachments (2)

Alert-title_apps.diff (10.0 KB ) - added by humdinger 9 years ago.
no more translated BAlert titles in apps
Alert-title_prefs.diff (5.2 KB ) - added by humdinger 9 years ago.
updated diff to remove translation of BAlert titles

Download all attachments as: .zip

Change History (7)

by humdinger, 9 years ago

Attachment: Alert-title_apps.diff added

no more translated BAlert titles in apps

comment:1 by humdinger, 9 years ago

Has a Patch: set

comment:2 by anevilyak, 9 years ago

The changes to AutoConfig.h are incorrect. "Authentication" is the right english word. Also, I don't remember right now and am at work, do BAlerts appear in Deskbar's window list? If so, this change will mean the windows no longer have localized titles there. The thread names are relatively unimportant since they won't affect the actual crash backtrace.

by humdinger, 9 years ago

Attachment: Alert-title_prefs.diff added

updated diff to remove translation of BAlert titles

comment:3 by humdinger, 9 years ago

Dunno how that "Authenication" thing got back in. Though I did an "svn up" before making the changes... Good catch! I removed that chunk and uploaded an updated diff.
BAlerts don't show up in the Deskbar list of windows. So, I guess it's alright to apply the changes. Thanks for having a look.

comment:4 by axeld, 9 years ago

I could imagine that different decorators actually show the window titles for alerts as well, so maybe this is a premature change, I dunno, though, if that's really something we would want.

comment:5 by humdinger, 9 years ago

Resolution: invalid
Status: newclosed

Didn't think of that... Closing the ticket as invalid.

Note: See TracTickets for help on using tickets.