Opened 12 years ago

Closed 12 years ago

#6401 closed enhancement (fixed)

Minimal string changes in dstcheck (Patch)

Reported by: humdinger Owned by: humdinger
Priority: normal Milestone: R1
Component: Applications/Command Line Tools Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All


Corrected wrong linebreak. Small changes to the displayed text.
Though I could apply the patch myself, I guess there should be the opportunity of discussion. If nobody has objections/improvements I'll commit it in a few days.

Attachments (2)

dstcheck.diff (853 bytes ) - added by humdinger 12 years ago.
string patch for dstcheck
dstdeck.diff (1.2 KB ) - added by humdinger 12 years ago.
updated diff

Download all attachments as: .zip

Change History (7)

by humdinger, 12 years ago

Attachment: dstcheck.diff added

string patch for dstcheck

comment:1 by humdinger, 12 years ago

patch: 01

comment:2 by axeld, 12 years ago

Well, I like the original version better of the first change, but I like your second change better than what was there before. Just my opinion, anyway.

comment:3 by humdinger, 12 years ago

What was bugging me in the original, was that the linebreak was in the middle of the displayed time. I thought putting the time in a separate line would improve visibility, but I agree, it looked a bit funny...
I updated the patch to lose the "Currently", and putting the sentence in a new line, thereby gaining enough space not to run into a linebreak. Since " " at the end of a string is trouble for localization, I added a " " explicitely outside the B_TRANSLATE(). Hope that's OK.

Last edited 12 years ago by humdinger (previous) (diff)

by humdinger, 12 years ago

Attachment: dstdeck.diff added

updated diff

comment:4 by axeld, 12 years ago

I like that better, yes, although I would still get rid of the colon; at least I wouldn't put one there when writing: "It's now 4:42." :-)

comment:5 by humdinger, 12 years ago

Resolution: fixed
Status: newclosed

OK, I removed the colon. Committed with hrev37810.

Note: See TracTickets for help on using tickets.