Opened 9 years ago

Closed 8 years ago

#6503 closed enhancement (fixed)

[patch] Device manager classifies scsi drives as 'unknown'

Reported by: kallisti5 Owned by: kallisti5
Priority: normal Milestone: R1
Component: Applications/Devices Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

This is reflecting on my previous moving ACPI nodes out of 'Unknown devices'

SCSI (ATA) devices are also listed as unknown devices.

The ATA device tree we are being passed is pretty hard identify to objects in. This is a patch to identify SCSI devices on the scsi bus and display some basic information on them and breaks them out from 'Unknown devices' as SCSI/ATA end points are pretty important. See screenshots for an example of how it works.

I am not sure this is the final direction things need to go, the kernel identification of ATA/IDE controllers right now is pretty funky. I put SCSI devices in 'Computer' category for now as they don't make sense under the 'Mass storage controller' category... Ideally they need to be under the controllers in the category view... but thats not implimented yet. I went with the side of caution.

A few cosmetic tab repairs are also included.

Attachments (3)

SCSI category.png (46.3 KB ) - added by kallisti5 9 years ago.
SCSI connection.png (101.1 KB ) - added by kallisti5 9 years ago.
scsi-device-patch-r1.diff (6.1 KB ) - added by kallisti5 9 years ago.
scsi device patch hrev1

Download all attachments as: .zip

Change History (11)

by kallisti5, 9 years ago

Attachment: SCSI category.png added

by kallisti5, 9 years ago

Attachment: SCSI connection.png added

comment:1 by kallisti5, 9 years ago

Has a Patch: set

by kallisti5, 9 years ago

Attachment: scsi-device-patch-r1.diff added

scsi device patch hrev1

comment:2 by stippi, 9 years ago

Can you give a link to the other ticket? I've tried to look it up by component, but was unable to find it.

in reply to:  2 comment:3 by kallisti5, 9 years ago

Replying to stippi:

Can you give a link to the other ticket? I've tried to look it up by component, but was unable to find it.

hrev37757 #6350

comment:4 by tqh, 9 years ago

They should probably be under Mass storage controller. If you want you can do 'cat /dev/acpi/namespace' to see the tree from ACPI's point of view. The names are pretty cryptic atm. See source:haiku/trunk/src/add-ons/kernel/bus_managers/acpi/acpi_ns_dump.cpp for the impl of that.

in reply to:  4 comment:5 by kallisti5, 9 years ago

Replying to tqh:

They should probably be under Mass storage controller. If you want you can do 'cat /dev/acpi/namespace' to see the tree from ACPI's point of view. The names are pretty cryptic atm. See source:haiku/trunk/src/add-ons/kernel/bus_managers/acpi/acpi_ns_dump.cpp for the impl of that.

Yeah, taking a step back and looking at this you are probably right. (it's been a few months since I made this patch)

Let me do a quick rework of this patch and I will re-post it here when it is more rounded.

Thanks!

comment:6 by kallisti5, 8 years ago

Owner: changed from nobody to kallisti5
Status: newassigned

comment:7 by kallisti5, 8 years ago

modified patch applied in hrev42721

comment:8 by kallisti5, 8 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.