CannaIM deskbar replicant popup menu not working; replicant handle menu displayed instead.

[koki@…]

When installing Canna input method, a replicant is loaded in the Deskbar.

Clicking on this replicant with the mouse should display a popup menu, but in Haiku it doesn't. Instead, the replicant handle menu is displayed.

Was not sure what component this belonged to; feel free to change it if necessary.

[korli]

This is dependent on message scripting feature. It is being fixed, but could be longer than expected.

[korli]

FYI, several scripts which have to work first :

hey Deskbar get Messenger of Shelf of View Status of Window Deskbar hey Deskbar get Name of Replicant 0 of Shelf of View Status of Window Deskbar hey Deskbar get View of Replicant 0 of Shelf of View Status of Window Deskbar

BTW I think Haiku input_server should be changed to simply query (doesn't work on R5 because the replicant has no name) : hey Deskbar get View of Replicant MethodReplicant of Shelf of View Status of Window Deskbar

[korli]

should be fixed in revision 17841

[koki@…]

Nice improvements! We are getting close.

As tested on build 17843, CannaIM deskbar popup menu now works, but there two small oddities:

1) For some reason the submenu that should display among other things the About window when Canna is in Japanese mode appears empty.

2) The replicant handle is still being displayed; it should not.

Should I open separate bug reports for the above?

[korli]

About these oddities, they must be related to our interface kit implementation: the canna method and method replicant were working on R5 last time I tried. Stefano, could you have a look at the menu oddity ?

[jackburton]

"1) For some reason the submenu that should display among other things the About window when Canna is in Japanese mode appears empty."

I'll have a look at this. Might be a bug in BShelf or BDragger.

"2) The replicant handle is still being displayed; it should not."

This could be related to #116.

[bxi07354@…]

(In reply to comment #6)

"1) For some reason the submenu that should display among other things the About window when Canna is in Japanese mode appears empty."

BMenu::Archive doesn't do deep.

if (err == B_OK && deep) {

TODO store items and rects

}

[korli]

Popup menu is now working somehow. Weirdly it seems to appear disabled, and I don't know why.

[bxi07354@…]

The mistake was found by BMenu::InitData(BMessage *data). data->FindBool("_disable", &fEnabled);

BSeparatorItem is not displayed. status_t BSeparatorItem::Archive(BMessage* archive, bool deep) const {

if (!archive->HasString(B_CLASS_FIELD))

• archive->AddString(B_CLASS_FIELD, "BMenuItem");

+ archive->AddString(B_CLASS_FIELD, "BSeparatorItem");

The return value(item) is not necessarily MethodMenuItem*. void MethodReplicant::MouseDown(BPoint point) {

.... BMenuItem *item = fMenu.Go(where, true, true, BRect(where - BPoint(4, 4),

where + BPoint(4, 4)));

if (item && cast_as(item, MethodMenuItem)) {

BMessage msg(IS_SET_METHOD); msg.AddInt32("cookie", ((MethodMenuItem *)item)->Cookie()); ....

[korli]

This was somehow fixed in revision 18071. Is there anything still valid ?

[korli]

barber, I applied the last part of your patch in revision 18093, and even tested it successfully. Thanks a lot!

[bxi07354@…]

(In reply to comment #6)

"1) For some reason the submenu that should display among other things the About window when Canna is in Japanese mode appears empty."

This was solved by revision 18093. Thank you.

[korli]

tested again in revision 18880. The menu itself is empty in the deskbar replicant.