Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6676 closed enhancement (fixed)

Less padding in FileType-Add-on window (patch)

Reported by: humdinger Owned by: yourpalal
Priority: normal Milestone: R1
Component: Preferences/FileTypes Version: R1/Development
Keywords: padding Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev38827.

Currently the FileTye add-on shows a bit too much vertical padding between e.g. the radio buttons. I'm not totally sure when dealing with layouting, so I'd appreciate if somebody looked over this tiny patch...

Attached are the patch, and screenshots of old and new.

Attachments (4)

FileType_addon_window.diff (1.8 KB) - added by humdinger 9 years ago.
The patch
FileTypes_old.png (34.6 KB) - added by humdinger 9 years ago.
FileType add-on - old
FileTypes_new.png (34.1 KB) - added by humdinger 9 years ago.
FileType add-on - new
FileTypes_Russian.png (34.0 KB) - added by diver 9 years ago.
FileType window is way to wide

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by humdinger

Attachment: FileType_addon_window.diff added

The patch

comment:1 Changed 9 years ago by humdinger

Has a Patch: set

Changed 9 years ago by humdinger

Attachment: FileTypes_old.png added

FileType add-on - old

Changed 9 years ago by humdinger

Attachment: FileTypes_new.png added

FileType add-on - new

comment:2 Changed 9 years ago by anevilyak

Owner: changed from axeld to yourpalal
Status: newassigned

comment:3 Changed 9 years ago by diver

BTW same should be applied to the Mount settings window.

comment:4 Changed 9 years ago by yourpalal

A quick look over the patch looks good, although I would leave the padding as-is for version box, at least the horizontal padding. With the h-padding at 0, the elements making up the version look a bit squished. The vertical padding can(and is) be reduced though.

Changed 9 years ago by diver

Attachment: FileTypes_Russian.png added

FileType window is way to wide

comment:5 Changed 9 years ago by axeld

I agree with yourpalal about the padding in the version box.

comment:6 Changed 9 years ago by humdinger

Resolution: fixed
Status: assignedclosed

Thanks yourpalal. You're right with the horizontal padding. I put it back. Patched with hrev38839.
diver, I'm not sure about the window size. I guess it's on purpose to accommodate a reasonable width for the the long description.

BTW, resizing the window horizontally leaves artifacts from the BBoxes...

comment:7 Changed 9 years ago by humdinger

Has a Patch: unset
Note: See TracTickets for help on using tickets.