Missing volatile keyword

[kaliber]

Clang says:

src/system/kernel/arch/x86/vm86.cpp:573:2: error: indirection of non-volatile null pointer will be deleted, not trap
        *((uint32 *)0) = 0xdeadbeef;
        ^~~~~~~~~~~~~~
src/system/kernel/arch/x86/vm86.cpp:573:2: note: consider using __builtin_trap() or qualifying pointer with 'volatile'

[Disreali]

what does that mean?

[phoudoin]

I guess clang will be happier if it was written as follow:

*((volatile uint32 *)0) = 0xdeadbeef;

[Disreali]

That is how it is currently written. see ​here

I just watched the ​"libclang: Thinking Beyond the Compiler" video and if I understand correctly, the error is the underlined *((uint32 *)0) part, . Clang is suggesting a replacement:

 note: consider using __builtin_trap() or qualifying pointer with 'volatile'

However, I have no real idea what the 0xdeadbeef is all about, so take with a grain of salt.

[waddlesplash]

Clang support has been merged to master.