#689 closed bug (fixed)
[ping] 2 small fixes
Reported by: | Owned by: | korli | |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | - General | Version: | |
Keywords: | Cc: | diver | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
- errx's error message should be ended with a new line
- the type of fromlen in main function should match the type of the last
argument in recvfrom. So, fromlen should be "int" instead of "size_t".
Attachments (1)
Change History (9)
by , 18 years ago
comment:1 by , 18 years ago
Cc: | added |
---|
comment:2 by , 18 years ago
Cc: | added |
---|
comment:3 by , 18 years ago
Thanks for the patch. On the second problem, I think it would be better anyway to use socklen_t in sys/socket.h instead of int. Axel, could changing to socklen_t make Haiku less BeOS compatible, etc.. ?
comment:4 by , 18 years ago
It would only affect source compatibility, and I wouldn't have a problem with that (but I don't expect any problems with this either) :-) IOW I'd welcome socklen_t.
comment:5 by , 18 years ago
I'm wondering : we could only change it for our libnetwork.so and our headers, not the compat net libs and legacy network headers ?
comment:6 by , 18 years ago
Status: | new → closed |
---|
comment:7 by , 18 years ago
Resolution: | → fixed |
---|
comment:8 by , 18 years ago
Committed the relevant part of the patch, and changed size parameter type of sys/socket.h functions to socklen_t for our own headers and libnetwork.so in revision 17911.
patch to fix those problems