Opened 9 years ago

Closed 9 years ago

#6943 closed bug (fixed)

"Search web" not working

Reported by: humdinger Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev39660.

In Web+ you can mark a word and right-click it to get a "Search web" in the context menu. This item should open the search site specified in Web+'s settings with the selected word, I guess. It doesn't.

Also, just like ALT+H to open the start page, a shortcut for the websearch would come in handy. We should reserve ALT+S for a future saving function. Maybe ALT+K? I think Firefox has this shortcut.

Change History (2)

comment:1 by leavengood, 9 years ago

Owner: changed from stippi to leavengood
Status: newassigned

I've fixed the "Search web" context menu for now in Web+ revision 567, but like the URL bar search we still need proper search engine management and OpenSearch.org support, instead of hard-coding Google.

As for the shortcut, I really don't know if it is needed with the URL bar search feature. I know that in Firefox with it's search field and Chrome with it's URL bar search I rarely open google.com directly. In fact until now in Web+ I did not even use the feature where you can have new tabs go to the search site. I might even remove that at some point.

I'll leave this ticket open for now to wait for your comments Humdinger. Also I've been working on some of your tickets at http://webpositive.haiku-os.org (copied from mmlr's server.) Have you been getting email notifications?

comment:2 by humdinger, 9 years ago

Resolution: fixed
Status: assignedclosed

I don't think I got notifications of the old Web+ tickets, but I see your commit messages. Great stuff, I hope we'll see a new Web+ package soon. :)

I agree to close this ticket (actually I'll do that right now). A search directly from the search bar sounds much better anyway, though I haven't seen it yet, of course. Now, if you also find a nice way to also include search through the bookmarks (tile,url, keywords) there, it'd be perfect! Of course, having web and bookmark search, plus history and regular URL input there is a little challenge in GUI design, I guess...
Great to see you working on Web+ again a bit!

Note: See TracTickets for help on using tickets.