Found string highlighting colour

[humdinger]

This is hrev39847.

Web+ uses the same highlighting colour for found strings as for selected text. While it's no problem when selecting text (I know roughly where I clicked in the text), for search results, I really have to look closely. If possible, I'd suggest a much brighter colour for highlighting a found string. Also, it'd be nice if all matching strings on a page would be highlighted, a little darker, and only the one at the current position really bright.

This is #FFFF00 and #FFD452:

[humdinger]

brightler highlighting colour

[leavengood]

There is a similar issue logged on the Web+ Trac which I took over so I'll take this ticket too. I may see about mimicking some of Chrome's search and some of Safari's. I say if you are making a new browser you might as well take what you can from the rest.

[leavengood]

Well I don't know about highlighting all matches, but I did make the selection color a brighter orange in ​WebPositive r581. Even though there is a "text search highlight color" it seemed the search was using the inactive highlight color, so I made them all the bright orange.

The searching definitely has room for improvement, and maybe the way it is done now was causing the use of the inactive highlight color.

I suppose I could see how the bright yellow looks.

[luroh]

Moving Web+ enhancements out of R1 milestone.

[pulkomandy]

The current bright orange feels a bit out of place, as other apps in Haiku (anything BTextControl based) uses reverse video (usually white text on black background). Also, BTextControl selects the current search result, I think that makes sense and maybe WebKit could do the same.

[nephele]

The color used for this, which is now grayish. can be defined with the css system colors aswell.

Perhaps we should decide on a niceish dark and light variant to use? I don't think we will easily get reverse video here.

[nephele]

With the next version of haikuwebkit this may be a bit better. We now supply our own highlight color

​https://github.com/haiku/haikuwebkit/commit/eb5d159be1f14f6c4ff9a055543bee9ccd5e57c9#diff-e8f8d50f546fef1c2ed9fb35e9e5037863cb4dc9026facda99d0aaccfc329ac2R433

Tell me if this works better, otherwise we will need to change it a bit still.