Opened 9 years ago

Last modified 3 years ago

#7034 assigned enhancement

Found string highlighting colour

Reported by: humdinger Owned by: leavengood
Priority: low Milestone: Unscheduled
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

This is hrev39847.

Web+ uses the same highlighting colour for found strings as for selected text. While it's no problem when selecting text (I know roughly where I clicked in the text), for search results, I really have to look closely. If possible, I'd suggest a much brighter colour for highlighting a found string. Also, it'd be nice if all matching strings on a page would be highlighted, a little darker, and only the one at the current position really bright.

This is #FFFF00 and #FFD452:

brightler highlighting colour

Attachments (1)

Finding-bright.png (38.8 KB ) - added by humdinger 9 years ago.
brightler highlighting colour

Download all attachments as: .zip

Change History (6)

by humdinger, 9 years ago

Attachment: Finding-bright.png added

brightler highlighting colour

comment:1 by leavengood, 9 years ago

Owner: changed from stippi to leavengood
Status: newassigned

There is a similar issue logged on the Web+ Trac which I took over so I'll take this ticket too. I may see about mimicking some of Chrome's search and some of Safari's. I say if you are making a new browser you might as well take what you can from the rest.

comment:2 by leavengood, 8 years ago

Well I don't know about highlighting all matches, but I did make the selection color a brighter orange in WebPositive r581. Even though there is a "text search highlight color" it seemed the search was using the inactive highlight color, so I made them all the bright orange.

The searching definitely has room for improvement, and maybe the way it is done now was causing the use of the inactive highlight color.

I suppose I could see how the bright yellow looks.

comment:3 by pulkomandy, 5 years ago

Priority: normallow

comment:4 by luroh, 5 years ago

Milestone: R1Unscheduled

Moving Web+ enhancements out of R1 milestone.

comment:5 by pulkomandy, 3 years ago

The current bright orange feels a bit out of place, as other apps in Haiku (anything BTextControl based) uses reverse video (usually white text on black background). Also, BTextControl selects the current search result, I think that makes sense and maybe WebKit could do the same.

Note: See TracTickets for help on using tickets.