Paladin Crashes On "About Paladin"

[darkwyrm]

The current development version of Paladin crashes under GCC4 hybrid hrev40237 merely by choosing About Paladin from the File menu.

(gdb) bt
#0  0x005ea72a in strcmp () from /boot/system/lib/libroot.so
#1  0x01df7cff in TranslatorSettings::FindTranSetting ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#2  0x01df7dd5 in TranslatorSettings::SetGetBool ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#3  0x01df193b in be_jpeg_std_error ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#4  0x01df2f1b in JPEGTranslator::Decompress ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#5  0x01df413e in JPEGTranslator::DerivedTranslate ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#6  0x01df76d2 in BaseTranslator::BitsTranslate ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#7  0x01df771a in BaseTranslator::Translate ()
   from /boot/system/add-ons/Translators/JPEGTranslator
#8  0x007fc286 in BTranslatorRoster::Translate ()
   from /boot/system/lib/libtranslation.so
#9  0x007f8f5d in BTranslationUtils::GetBitmap ()
   from /boot/system/lib/libtranslation.so
#10 0x007f92b6 in BTranslationUtils::GetBitmap ()
   from /boot/system/lib/libtranslation.so
#11 0x002371d5 in AboutView::AboutView ()
#12 0x00236baf in AboutWindow::AboutWindow ()
#13 0x002475ae in App::AboutRequested ()
---Type <return> to continue, or q <return> to quit---
#14 0x003a2aaa in BApplication::DispatchMessage ()
   from /boot/system/lib/libbe.so
#15 0x003ad454 in BLooper::task_looper () from /boot/system/lib/libbe.so
#16 0x003a3044 in BApplication::Run () from /boot/system/lib/libbe.so
#17 0x0024b159 in main ()

[phoudoin]

I reproduce the crash too, but mine is in TranslatorSettings::LoadSettings() instead, while your is when these settings are accessed. Do you have a JPEGTranslator_settings file in your ~/config/settings folder? I've none here while having this crash.

BTW, why the 'JPG ' type is passed in GetBitmap()? AFAICT, JPEGTranslator type is 'JPEG', while JPEG2000 is 'JP2 '...

[phoudoin]

I does it too with previous version of Paladin. I suspect some issue with runtime_loader and weak symbols support...

[phoudoin]

Paladin do have a GLOBAL gSettings object, which seems to confuse runtime_loader when loading an (here, translator) add-on with same GLOBAL symbol.

And guess who also export a "gSettings" symbol? Yes, both JPEGTranslator and JPEG2000Translator does. Which, for unknown reason, are each time resolved by runtime_loader as the address of Paladin's gSettings symbol.

Which leads to the crash, as some warning trigger a lookup for "readWarning" settings in JPEGTranslator.

[phoudoin]

While the runtime_loader behavior should be verified here, I will made local these symbols in translators, which should have been in the first place.

[phoudoin]

Reassign, so Ingo could give a look.

[phoudoin]

The crash should not happend anymore since hrev40245. The root issue still remains, I fear.

Ingo, could you give a look? I fear some image order symbol lookup issue here, but I'm not at ease with weak symbol changes yet.

[bonefish]

Cf. hrev40248.