BTextView::HideTyping not implemented

[korli]

ScreenSaver preferences has some password controls which expose the password at the moment.

[jackburton]

Should it also show some "*" or just hide what is being typed ?

[korli]

Stefano, I added a B_UTF8_BULLET in InterfaceDefs.h (3 bytes) :) I tried to have the BTextView use it instead of real chars, but I didn't got it to work correctly. Multibyte seems to not help here, ie in _BTextGapBuffer_::GetString(int32 fromOffset, int32 numChars), I thought numChars were really characters and not bytes, but seeing the code I'm not sure.

[jackburton]

(In reply to comment #2)

Stefano, I added a B_UTF8_BULLET in InterfaceDefs.h (3 bytes) :) I tried to have the BTextView use it instead of real chars, but I didn't got it to work correctly. Multibyte seems to not help here, ie in _BTextGapBuffer_::GetString(int32 fromOffset, int32 numChars), I thought numChars were really characters and not bytes, but seeing the code I'm not sure.

Yeah, almost every function in BTextView handles bytes, not characters. The naming of the parameters is often misleading and should be definitely changed.

[jackburton]

Fixed in hrev18837. Note that there are still problems, but a new bug should be opened for them.

[jackburton]

Replying to jackburton:

Fixed in hrev18837. Note that there are still problems, but a new bug should be opened for them.

By the way, I need some info on how beos behaves here: i.e. What do the public methods (Text(), ByteAt(), etc.) return when typing is hidden ? The real text or the displayed text (bullet characters) ?

[kvdman]

Hi,

I've tested such applications as GIM ICQ, BeMSN, and others I can't think of at the moment. The asteriks , when typing a password aren't implemented!

Thanks

[ksmith]

The bullets are not being properly displayed. Could this be because the number of bytes taken by a bullet is not being properly calculated?

If you change the bullets to asterisks in TextGapBuffer.cpp, they actually show up in the textview when you are typing. However, when you leave the textview, the formatting (spacing) of the asterisks change, and I am not sure why.

[jackburton]

Replying to ksmith:

The bullets are not being properly displayed. Could this be because the number of bytes taken by a bullet is not being properly calculated?

Yes, it's for that reason. Moreover, I never finished implementing that feature correctly, because I cannot test how beos behaves. I mean: which public methods of BTextView return the real text and which ones return the bullets ?

[stippi]

It wasn't really UTF8 problems, but rather a mix up of what the selection offsets apply to (the real text) and when they were used for the bullet text. And the same about the width offsets of characters, the wrong text was used, with the wrong byte offset mapping for the characters. Should be fixed now since hrev22787, with my limited tests, I couldn't find anymore problems. Feel free to reopen if you spot anymore problems though.