Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7177 closed enhancement (fixed)

Deskbar should disable expand options in preference window when not in expando mode

Reported by: jscipione Owned by: tqh
Priority: normal Milestone: R1
Component: Applications/Deskbar Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

"Show Application Expander" and "Expand New Applications" in the Deskbar preferences only work in Expando mode, however, this is not communicated to the user. This ticket contains a patch which disables these options in the preference window when not in expando mode and re-enables them in expando mode.

Attachments (1)

Deskbar Disable Expand Options 1.diff (3.0 KB) - added by jscipione 8 years ago.
Simplify conditional

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by jscipione

Has a Patch: set

Changed 8 years ago by jscipione

Simplify conditional

comment:2 Changed 8 years ago by tqh

Owner: changed from axeld to tqh
Status: newin-progress

comment:3 Changed 8 years ago by tqh

Resolution: fixed
Status: in-progressclosed

Commited in hrev40326.

comment:4 Changed 8 years ago by humdinger

Sorry for commenting on a closed ticket. The patch was just too quickly applied... Now that's something you don't read too often... :)

I was wondering if a tooltip on the disabled option would be appropriate: "Expanding is not available with Deskbar in horizontal mode." Or "bar mode"? Something like that...

comment:5 Changed 8 years ago by tqh

I don't agree with you:

  • it improves the behaviour over the old way
  • it is clean code
  • it is easy to change the behaviour based on test and feedback.
  • further changes can be reported in new tickets

Development should happen in the version control system, not outside it. How often do you download and test patches and give feedback here?

comment:6 in reply to:  4 Changed 8 years ago by axeld

Replying to humdinger:

I was wondering if a tooltip on the disabled option would be appropriate: "Expanding is not available with Deskbar in horizontal mode." Or "bar mode"? Something like that...

Yes, something like that would indeed be nice.

To tqh: I think you managed to misread humdinger's comment; we was not criticizing you for applying the patch so fast, he just mentioned that as an excuse that he didn't manage to comment before it was applied.

comment:7 Changed 8 years ago by tqh

I didn't take it as critique, although I can see how my reply might suggest that.

I don't think I misread him, I was just explaining that it should go into the development tree if it is ok and further changes like the ones Humdinger want can be taken from there if it has already been landed.

Discussion and feedback happens best after evaluation.

comment:8 Changed 8 years ago by humdinger

I think we're all on the same page here. To clarify, not in any way did I want to imply that the patch was added prematurely. Axel saw right through me: I only took it as lame excuse for being too lazy to file a new ticket... :)

comment:9 Changed 8 years ago by tqh

Yes. The reason it happened that fast was because we were already talking over IRC and I'd forget what was said and done if I'd leave it for later.

Note: See TracTickets for help on using tickets.