E-mail preferences freezes when new mail account is created

[taos]

With hrev40624 the E-mail preferences window freezes when creating a new mail account (both POP3 and IMAP):
Hitting the OK button of the "Create new account - Account settings" dialogue window results in an immediate increase of CPU usage. The E-mail preferences window becomes unresponsive. CPU usage drops as soon as the mail_daemon thread is killed.

A new mail account can be created if Haiku is booted in safe mode.

An existing account can be edited without problems.

A new mail account can be created by copying an existing account (in /boot/home/config/settings/Mail/accounts), renaming, and editing it.

[taos]

Sorry, it's of course the E-mail w>Create new account thread or the E-mail team that must be killed in order to regain a responsive system. Debug output ("E-mail.txt") and part of syslog ("syslog_short.txt") are attached (ignore "syslog_short.2.txt").

BTW I noticed that it's sometimes (but not always) possible to create an IMAP account. That can be used as a workaround for creating a POP3 account: Start E-mail preferences, add new account, choose IMAP, fill in all blanks, and only then choose POP3 from pull down menu before you finally hit the OK button. If you choose POP3 before completing the window freezes.

[czeidler]

Could you check if hrev40798 fix it? Does the fetched server looks fine?

[taos]

Problem still exists with hrev40806. Debug output is attached as "Debug_E-mail.txt", last part of syslog as "syslog_short.2.txt".

[czeidler]

At least the crash should be fixed now. But its strange that nothing comes back from the server. Which provider are you using? Please tell me the domain name of your email address.

[czeidler]

The crash occurres when removing the first char in ConvertFromDNSName:

BString
DNSTools::ConvertFromDNSName(const BString& string)
{
	if (string.Length() == 0)
		return string;

	BString outString = string;
	int32 dot = string[0];
	int32 nextDot = dot;
	outString.Remove(0, 1);

I'm a bit lost how could this happen? The code where this is called looks thread safe... It allways crashes in realloc in the BString class see debug backtrace. Could somebody help me out here?

[czeidler]

Debug bt

[korli]

It seems HEAP_WALL is activated in malloc wrapper and you just hit the check_wall().

I suppose the above code works in a unit testcase (did you check this?), so there is memory corruption happening somewhere. BTW outString copy should only happen in BString::Remove().

[czeidler]

Think I found the problem in hrev40895.

[taos]

Thanks. Everything now works as expected when creating new mail accounts - no more freezes (tested with hrev40913).