Opened 8 years ago

Last modified 2 years ago

#7293 new bug

Disk system add-ons need to be translated (which will display in DriveSetup)

Reported by: blutigerWilliam Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/DriveSetup Version: R1/Development
Keywords: Cc: przemub@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Some Strings, especially the file system names, in DriveSetup remain untranslated in the german localization of haiku.

I use hrev40501 GCC4hybrid.

Attachments (3)

screenshot_drivesetup.png (53.6 KB) - added by blutigerWilliam 8 years ago.
commit-4c1e34b.diff (3.4 KB) - added by przemub 6 years ago.
2012-12-22-170550_1440x900_scrot.png (25.8 KB) - added by przemub 6 years ago.

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by blutigerWilliam

Attachment: screenshot_drivesetup.png added

comment:1 Changed 8 years ago by siarzhuk

Please check revisions after hrev40734. Frankly speaking it is not clear what is your problem. Please explain - which string should be translated. Thanks.

comment:2 Changed 8 years ago by diver

This ticket is about "* File System" labels, see here.

comment:3 Changed 8 years ago by blutigerWilliam

Diver is right, that is exactly, what i mean.

Regards

comment:4 Changed 6 years ago by przemub

Cc: przemub@… added

Changed 6 years ago by przemub

Attachment: commit-4c1e34b.diff added

comment:5 Changed 6 years ago by przemub

Has a Patch: set

comment:6 Changed 6 years ago by korli

przemub,

could you please post a screenshot with your patch applied?

Thanks!

Changed 6 years ago by przemub

comment:7 in reply to:  6 Changed 6 years ago by przemub

Replying to korli:

przemub,

could you please post a screenshot with your patch applied?

Thanks!

Before taking this screenshot I've added translations of "Be File System" and "Intel Partition Map" string to Polish catkey file.

comment:8 Changed 6 years ago by mmadia

Is this patch OK to commit?

comment:9 Changed 6 years ago by stippi

To me, the patch looks very strange. How can it work? I thought B_TRANSLATE is a macro and everything is extracted by a tool (collect_cat_keys?). But "diskSystem.prettyName()" will only expand to a readable string when the program is actually running, no? What string ended up in the locale file? Am I missing something?

comment:10 Changed 6 years ago by stippi

Ok, I think I understand. The patch would actually work if all file systems would be added to the catalogs, but this is wrong still, since the translations are added in the wrong catalogs. The disk system add-ons themselves need to be translated, not DriveSetup.

comment:11 Changed 6 years ago by mmadia

Summary: Untranslated names of file systems in DriveSetupDisk system add-ons need to be translated (which will display in DriveSetup)

comment:12 in reply to:  10 Changed 6 years ago by siarzhuk

Replying to stippi:

Ok, I think I understand. The patch would actually work if all file systems would be added to the catalogs, but this is wrong still, since the translations are added in the wrong catalogs.

AFAIR the list of B_TRANSLATE_MARK definitions for known file system names can be used to help harvest ones for catkeys at the build time. Filtering varaible with file system name throught B_TRANSLE at run-time will do the final localiation work.

The disk system add-ons themselves need to be translated, not DriveSetup.

In case those names are just cosmetic and do not used for any kind of identification. AFAIR most of post-localization regressions were caused by such straightforward technique.

comment:13 Changed 2 years ago by pulkomandy

Has a Patch: unset

Maybe we can use B_TRANSLATE_SYSTEM_NAME, which gets the name from the add-on resources?

Last edited 2 years ago by pulkomandy (previous) (diff)
Note: See TracTickets for help on using tickets.