Opened 14 years ago
Last modified 4 years ago
#7293 new bug
Disk system add-ons need to be translated (which will display in DriveSetup)
Reported by: | blutigerWilliam | Owned by: | stippi |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Applications/DriveSetup | Version: | R1/Development |
Keywords: | localization | Cc: | przemub@… |
Blocked By: | Blocking: | ||
Platform: | All |
Description
Some Strings, especially the file system names, in DriveSetup remain untranslated in the german localization of haiku.
I use hrev40501 GCC4hybrid.
Attachments (3)
Change History (17)
by , 14 years ago
Attachment: | screenshot_drivesetup.png added |
---|
comment:1 by , 14 years ago
comment:4 by , 12 years ago
Cc: | added |
---|
by , 12 years ago
Attachment: | commit-4c1e34b.diff added |
---|
comment:5 by , 12 years ago
patch: | 0 → 1 |
---|
follow-up: 7 comment:6 by , 12 years ago
przemub,
could you please post a screenshot with your patch applied?
Thanks!
by , 12 years ago
Attachment: | 2012-12-22-170550_1440x900_scrot.png added |
---|
comment:7 by , 12 years ago
Replying to korli:
przemub,
could you please post a screenshot with your patch applied?
Thanks!
Before taking this screenshot I've added translations of "Be File System" and "Intel Partition Map" string to Polish catkey file.
comment:9 by , 12 years ago
To me, the patch looks very strange. How can it work? I thought B_TRANSLATE is a macro and everything is extracted by a tool (collect_cat_keys?). But "diskSystem.prettyName()" will only expand to a readable string when the program is actually running, no? What string ended up in the locale file? Am I missing something?
follow-up: 12 comment:10 by , 12 years ago
Ok, I think I understand. The patch would actually work if all file systems would be added to the catalogs, but this is wrong still, since the translations are added in the wrong catalogs. The disk system add-ons themselves need to be translated, not DriveSetup.
comment:11 by , 12 years ago
Summary: | Untranslated names of file systems in DriveSetup → Disk system add-ons need to be translated (which will display in DriveSetup) |
---|
comment:12 by , 12 years ago
Replying to stippi:
Ok, I think I understand. The patch would actually work if all file systems would be added to the catalogs, but this is wrong still, since the translations are added in the wrong catalogs.
AFAIR the list of B_TRANSLATE_MARK definitions for known file system names can be used to help harvest ones for catkeys at the build time. Filtering varaible with file system name throught B_TRANSLE at run-time will do the final localiation work.
The disk system add-ons themselves need to be translated, not DriveSetup.
In case those names are just cosmetic and do not used for any kind of identification. AFAIR most of post-localization regressions were caused by such straightforward technique.
comment:13 by , 8 years ago
patch: | 1 → 0 |
---|
Maybe we can use B_TRANSLATE_SYSTEM_NAME, which gets the name from the add-on resources?
comment:14 by , 4 years ago
Keywords: | localization added |
---|
Please check revisions after hrev40734. Frankly speaking it is not clear what is your problem. Please explain - which string should be translated. Thanks.